[LU-7064] llog_cancel_rec() does not detect errors from llog_declare_destroy()

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.9.0
• Affects Version/s: Lustre 2.8.0
• Labels: easy patch
• Severity: 3
• Assignee: WC Triage
• Reporter: John Hammond

Description

In llog_cancel_rec() the return values of llog_declare_destroy() and llog_write_rec() are never used:

        if ((llh->llh_flags & LLOG_F_ZAP_WHEN_EMPTY))
                rc = llog_declare_destroy(env, loghandle, th);

        th->th_wait_submit = 1;
        rc = dt_trans_start_local(env, dt, th);
        if (rc < 0)
                GOTO(out_trans, rc);

...

        rc = llog_write_rec(env, loghandle, &llh->llh_hdr, NULL,
                            LLOG_HEADER_IDX, th);
        if (rc == 0)
                loghandle->lgh_hdr->llh_count--;
        else
                ext2_set_bit(index, LLOG_HDR_BITMAP(llh));

        if ((llh->llh_flags & LLOG_F_ZAP_WHEN_EMPTY) &&
            (llh->llh_count == 1) &&
            (loghandle->lgh_last_idx == LLOG_HDR_BITMAP_SIZE(llh) - 1)) {
                rc = llog_trans_destroy(env, loghandle, th);

Comments

[Peter Jones]

Landed for 2.9

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/17999/
Subject: LU-7064 obd: detect errors from llog_declare_destroy()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 5d9275e2784942266f2c9cd03f9ad2f17fba0af4

[parinay v kondekar (Inactive)]

git hash 339e9adc - LU-6968 takes care of return value from llog_write_rec() .

[Gerrit Updater]

Parinay Kondekar ([e-mail]) uploaded a new patch: http://review.whamcloud.com/17999
Subject: LU-7064 detect errors from llog_declare_destroy()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 8151a65b2d3b047e440fffe049221faa3df38423