[LU-7317] error function not called upon error

• Type: Bug
• Resolution: Fixed
• Priority: Trivial
• Fix Version/s: Lustre 2.9.0
• Severity: 3
• Assignee: James Nunez (Inactive)
• Reporter: Aditya Pandit (Inactive)

Description

$ grep '|| \"' ./*.sh -r

./replay-ost-single.sh: $SETSTRIPE -i 0 -c 1 $DIR/$tfile || "setstripe failed"
./sanity-hsm.sh: dd if=$file2 of=/dev/null bs=1M || "cannot read '$file2'"
./sanity-lfsck.sh: [ $count2 -eq 2 ] || "(6) Fail to inject error: $count2"
./sanity-lfsck.sh: stat $DIR/$tdir/foo/f0 || "(18) f0 is not recovered"
./sanityn.sh: mv $DIR2/$tdir/d1/0 $DIR2/$tdir/d0/0 || "rename d1/0 d0/0 failed"
./sanity-quota.sh: set_ost_qtype "ug" || "enable ost quota failed"
./sanity-quota.sh: set_mdt_qtype "ug" || "enable mdt quota failed"
./sanity-quota.sh: $RUNAS unlinkmany $TESTFILE $ilimit || "unlink files failed"
./sanity-quota.sh: $RUNAS unlinkmany $TESTFILE $((ilimit + 1)) || "unlink failed"
./sanity-quota.sh: rmdir $DIR/${tdir}-1 || "unlink remote dir failed"
./sanity-quota.sh: set_ost_qtype "ug" || "enable ost quota failed"
./sanity-quota.sh: set_mdt_qtype "ug" || "enable mdt quota failed"
./sanity-quota.sh: set_ost_qtype "u" || "enable ost quota failed"
./sanity-quota.sh: set_mdt_qtype "u" || "enable mdt quota failed"
./sanity-quota.sh: set_ost_qtype "u" || "enable ost quota failed"
./sanity.sh: touch ${testdir}/${tfile} || "touch failed"
./sanity.sh: mknod ${testdir}/${tfile}-pipe p || "mknod failed"
./sanity.sh: rm -f ${testdir}/${tfile}-pipe || "pipe remove failed"
./sanity.sh: touch ${testdir}/${tfile} || "touch failed"
./sanity.sh: [ $unused -eq 0 ] || "$unused locks are not cleared"
./sanity.sh: do_facet ost1 "lsmod | grep -q obdecho || " \
./sanity.sh: "{ insmod ${LUSTRE}/obdecho/obdecho.ko || " \
./sanity.sh: rm -r $DIR/$tdir || "AGL for rmdir failed"

Everywhere it should have error "<string>"