Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-7589

update checkpatch.pl from upstream kernel

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • Lustre 2.11.0
    • None
    • None
    • 9223372036854775807

      Based on comments made in http://review.whamcloud.com/17661 to follow the upstream kernel coding style, it makes sense to update contrib/scripts/checkpatch.pl with recent upstream changes so that it follows current kernel CodingStyle, since changes like "printk strings allowed over 80 chars" that are in conflict to what our current checkpatch.pl complains about. Also the "if (rc == NULL)" and "if (rc != 0)" are deprecated upstream.

      However, we also have local checkpatch.pl modifications to complain about typedefs and cfs_ wrappers and such, so that shouldn't be removed. Possibly hooked into a more "vanilla" checkpatch.pl and the Lustre-specific deprecations in an external file?

            simmonsja James A Simmons
            adilger Andreas Dilger
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: