Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-7589

update checkpatch.pl from upstream kernel

Details

    • Improvement
    • Resolution: Fixed
    • Minor
    • Lustre 2.11.0
    • None
    • None
    • 9223372036854775807

    Description

      Based on comments made in http://review.whamcloud.com/17661 to follow the upstream kernel coding style, it makes sense to update contrib/scripts/checkpatch.pl with recent upstream changes so that it follows current kernel CodingStyle, since changes like "printk strings allowed over 80 chars" that are in conflict to what our current checkpatch.pl complains about. Also the "if (rc == NULL)" and "if (rc != 0)" are deprecated upstream.

      However, we also have local checkpatch.pl modifications to complain about typedefs and cfs_ wrappers and such, so that shouldn't be removed. Possibly hooked into a more "vanilla" checkpatch.pl and the Lustre-specific deprecations in an external file?

      Attachments

        Issue Links

          is related to

          Improvement - An improvement or enhancement to an existing feature or task. LU-11614 Modify checkpatch.pl to ignore 80 Character warning for CERROR, CWARN and CDEBUG

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            [LU-7589] update checkpatch.pl from upstream kernel
            gerrit Gerrit Updater added a comment -

            Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/28055/
            Subject: LU-7589 build: update checkpatch to ~4.13-rc1 kernel
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: bf8bcf7142dccaa92b2ea198efb34ec3004019e6

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/28055/ Subject: LU-7589 build: update checkpatch to ~4.13-rc1 kernel Project: fs/lustre-release Branch: master Current Patch Set: Commit: bf8bcf7142dccaa92b2ea198efb34ec3004019e6
            simmonsja James A Simmons added a comment -

            Patch at https://review.whamcloud.com/#/c/28055

            simmonsja James A Simmons added a comment - Patch at https://review.whamcloud.com/#/c/28055
            simmonsja James A Simmons added a comment -

            Yeah, my first ticket.

            simmonsja James A Simmons added a comment - Yeah, my first ticket.

            People

              simmonsja James A Simmons
              adilger Andreas Dilger
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: