[LU-7912] Stale comment in osc_page_transfer_add

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.13.0
• Severity: 3
• Assignee: Oleg Drokin
• Reporter: Oleg Drokin

Description

Ever since second patch in LU-3321 the comment became untrue, and then ops_inflight became deleted too making it even more out of date.

static void osc_page_transfer_add(const struct lu_env *env,
                                  struct osc_page *opg, enum cl_req_type crt)
{
        struct osc_object *obj = cl2osc(opg->ops_cl.cpl_obj);

        /* ops_lru and ops_inflight share the same field, so take it from LRU
         * first and then use it as inflight. */
        osc_lru_use(osc_cli(obj), opg);
}

Issue Links

• is related to: LU-3321 2.x single thread/process throughput degraded from 1.8

Comments

[Joseph Gmitter (Inactive)]

Patch has landed for 2.13.0

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/19115/
Subject: LU-7912 osc: Remove stale comment in osc_page_transfer_add
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 4a183613a6aa4c1cd4e6c8fc4c35945a640bda9f

[Oleg Drokin]

cl_io_cancel is no longer used and should be removed

[Oleg Drokin]

cl_locks_prune is also long gone after simplification, but is still referenced in cl_locks_prunelustre/osc/osc_cl_internal.h

[Oleg Drokin]

cl_page_top() is declared, but the body is long gone, so should be removed too.

[Oleg Drokin]

Also in CL_PAGE_INVOID_REVERSE macro there's "/* get to the bottom page. */" comment that makes no sense anymore
the part of code it was related to was removed in commit 18834a5554f2a5a8615f259be48bb2df9101b5a2

[Oleg Drokin]

it should also be noted that we have a bunch of comments referencing ll_cl_init(), but ll_cl_init() itself is long gone.

[Gerrit Updater]

Oleg Drokin ([e-mail]) uploaded a new patch: http://review.whamcloud.com/19115
Subject: LU-7912 osc: Remove stale comment in osc_page_transfer_add
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d785d0cd4bf0a0645ecfeb592fd520b5f1176bb9