[LU-8003] ll_ddelete() has obsolete reference to find_cbdata()

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.9.0
• Affects Version/s: Lustre 2.9.0
• Labels: easy
• Severity: 3
• Assignee: John Hammond
• Reporter: John Hammond

Description

After http://review.whamcloud.com/19164 the following comment and ifdefed out code in ll_ddelete() is obsolete and should be removed.

        /* Disable this piece of code temproarily because this is called
         * inside dcache_lock so it's not appropriate to do lots of work
         * here. ATTENTION: Before this piece of code enabling, LU-2487 must be
         * resolved. */
#if 0
        /* if not ldlm lock for this inode, set i_nlink to 0 so that                
         * this inode can be recycled later b=20433 */
        if (de->d_inode && !find_cbdata(de->d_inode))
                clear_nlink(de->d_inode);
#endif

Also the comment before ll_unlink() should be removed or corrected.

/* ll_unlink() doesn't update the inode with the new link count.
 * Instead, ll_ddelete() and ll_d_iput() will update it based upon if
 * there is any lock existing. They will recycle dentries and inodes
 * based upon locks too. b=20433 */
static int ll_unlink(struct inode *dir, struct dentry *dchild)

Issue Links

• is related to: LU-7925 ll_d_iput() can clear i_nlink for an inode in use
• is related to: LU-8058 Remove #if 0 sections older than 4 years