Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-8050

Drop llog_cookie usage from RPC on wire data

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.10.0
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      Originally, obdo::o_lcookie is for destroy with unlink cookie from MDS, it is obsolete in 2.8. And then, it is reused by the OSP to save on memory allocations as following comment:

              /*
               * this is a trick: to save on memory allocations we put cookie
               * into the request, but don't set corresponded flag in o_valid
               * so that OST doesn't interpret this cookie. once the request
               * is committed on OST we take cookie from the request and cancel
               */
      

      Currently, we needs more fields in the obdo structure to transfer more information from client to OST. The obdo::o_lcookie is good candidate. So we need adjust OSP logic to NOT use such field for non-onwire RPC data usage.

      Attachments

        Activity

          [LU-8050] Drop llog_cookie usage from RPC on wire data

          The patch has been landed to master.

          yong.fan nasf (Inactive) added a comment - The patch has been landed to master.

          Bobi Jam (bobijam@hotmail.com) uploaded a new patch: https://review.whamcloud.com/26395
          Subject: LU-8050 osp: not use obdo::o_lcookie for non-onwire RPC data
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: c6efa24974c3b9b20fca837a8d697ab9b58ef570

          gerrit Gerrit Updater added a comment - Bobi Jam (bobijam@hotmail.com) uploaded a new patch: https://review.whamcloud.com/26395 Subject: LU-8050 osp: not use obdo::o_lcookie for non-onwire RPC data Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: c6efa24974c3b9b20fca837a8d697ab9b58ef570

          Jinshan Xiong (jinshan.xiong@intel.com) merged in patch https://review.whamcloud.com/24876/
          Subject: LU-8050 osp: not use obdo::o_lcookie for non-onwire RPC data
          Project: fs/lustre-release
          Branch: pfl
          Current Patch Set:
          Commit: b324d313b92fd1da3f85280b7cc84ea9fa24a5cc

          gerrit Gerrit Updater added a comment - Jinshan Xiong (jinshan.xiong@intel.com) merged in patch https://review.whamcloud.com/24876/ Subject: LU-8050 osp: not use obdo::o_lcookie for non-onwire RPC data Project: fs/lustre-release Branch: pfl Current Patch Set: Commit: b324d313b92fd1da3f85280b7cc84ea9fa24a5cc

          Niu Yawei (yawei.niu@intel.com) uploaded a new patch: https://review.whamcloud.com/24876
          Subject: LU-8050 osp: not use obdo::o_lcookie for non-onwire RPC data
          Project: fs/lustre-release
          Branch: pfl
          Current Patch Set: 1
          Commit: c79ef5ad1e51d55fc85e7f2fdf91e10bf76029a0

          gerrit Gerrit Updater added a comment - Niu Yawei (yawei.niu@intel.com) uploaded a new patch: https://review.whamcloud.com/24876 Subject: LU-8050 osp: not use obdo::o_lcookie for non-onwire RPC data Project: fs/lustre-release Branch: pfl Current Patch Set: 1 Commit: c79ef5ad1e51d55fc85e7f2fdf91e10bf76029a0

          Fan Yong (fan.yong@intel.com) uploaded a new patch: http://review.whamcloud.com/19784
          Subject: LU-8050 osp: not use obdo::o_lcookie for non-onwire RPC data
          Project: fs/lustre-dev
          Branch: pfl
          Current Patch Set: 1
          Commit: e78d8a22c12d37084f8db64882793bd1c5013519

          gerrit Gerrit Updater added a comment - Fan Yong (fan.yong@intel.com) uploaded a new patch: http://review.whamcloud.com/19784 Subject: LU-8050 osp: not use obdo::o_lcookie for non-onwire RPC data Project: fs/lustre-dev Branch: pfl Current Patch Set: 1 Commit: e78d8a22c12d37084f8db64882793bd1c5013519

          People

            yong.fan nasf (Inactive)
            yong.fan nasf (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: