[LU-8075] Automatically add peer reviewers per the lustre.org community reviewers list

• Type: Task
• Resolution: Unresolved
• Priority: Minor
• Assignee: WC Triage
• Reporter: Cory Spitz

Description

There is a community list of code reviewers at http://wiki.lustre.org/Code_Reviewers. While at LUG 2016, John Hammond volunteered to write a script to automatically add the appropriate reviewers from the list for pull requests. So for example, code affecting the LNDs would automatically the individual signed up for LND work.

I'm not sure if the implementation can pull from the wiki page directly or if the data should be mirrored in a more accessible format. I assume that some refactoring may be in order as well. Further, if there are n reviewers listed for a given sub-system, Gerrit would add all n.

Issue Links

• duplicates: LU-11329 add get_maintainer.pl script from kernel

Comments

[Andreas Dilger]

Note that the get_maintainer.pl script is not automatically adding reviewers to patches. This would need someone to write a small bot to watch patches and add the reviewers, once we had some confidence that the script itself was doing a good job.

[Andreas Dilger]

The get_maintainers.pl script was added in patch https://review.whamcloud.com/33104 "LU-11329 utils: add get_maintainer.pl script".

[Cory Spitz]

I agree, 2 or 3 people sounds ideal. I'm a fan of the get-maintainers.pl method. That way, things are transparent.

[Andreas Dilger]

Cory, one option is to use a similar method as the MAINTAINERS list in the kernel, with the scripts/get-maintainers.pl script to map directories/files to individuals.

That said, I've found in the past that having too many people assigned to review a patch can be counter productive, since (I suspect) each individual assumes one of the other people assigned will do the actual work of reviewing the patch. If there are only 2 or 3 people assigned to review a patch it is more likely that they feel they are on the hook and actually do the review.