[LU-8178] recovery_duration value becomes negative

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.9.0
• Affects Version/s: Lustre 2.8.0
• Labels: patch
• Severity: 3
• Assignee: Peter Jones
• Reporter: Sergey Cheremencev

Description

Starting mds1: -o loop,user_xattr -o recovery_time_hard=60,recovery_time_soft=60  /tmp/lustre-mdt1 /mnt/mds1
Started lustre-MDT0000
recovery status
status: COMPLETE
recovery_start: 1385649466
recovery_duration: 18446744072323902150
completed_clients: 2/2
replayed_requests: 8737
last_transno: 8589950593
VBR: ENABLED
IR: DISABLED

Bug is occurred when /proc/fs/lustre/mdt/lustre-MDT0000/recovery_status is accessed after obd->obd_abort_recovery set to 0 and before target_finish_recovery call:

1. target_recovery_thread: obd->obd_recovering = obd->obd_abort_recovery = 0;
2. lprocfs_obd_rd_recovery_status: print("recovery_duration :", (obd->obd_recovery_end - obd->obd_recovery_start))
3. target_recovery_thread->target_finish_recovery: obd->obd_recovery_end = cfs_time_current_sec();

It seems bug exists for a long time.

Comments

[Joseph Gmitter (Inactive)]

patch has landed to master for 2.9

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/20381/
Subject: LU-8178 lproc: fix negative recovery_duration
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: ca62e637647f4d7c68bfb2b9f1b7a1597ae61381

[Gerrit Updater]

Sergey Cheremencev ([e-mail]) uploaded a new patch: http://review.whamcloud.com/20381
Subject: LU-8178 lproc: fix negative recovery_duration
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b96cbdba90406641cc21c04c17e54e6543245569