Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-8191

Candidates for conversion to static functions

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
    • Severity:
      3
    • Rank (Obsolete):
      9223372036854775807

      Description

      Here's a bunch of functions that are not declared in any .h files but are not static.

      Some have prototypes in .c files (also bad practice), mot I bet a lot of them could be converted to static:

      libcfs/libcfs/linux/linux-module.c:111:5: warning: symbol 'libcfs_ioctl_getdata' was not declared. Should it be static?
      lnet/klnds/o2iblnd/o2iblnd.c:588:1: warning: symbol 'kiblnd_debug_conn' was not declared. Should it be static?
      lnet/lnet/config.c:444:1: warning: symbol 'lnet_print_text_bufs' was not declared. Should it be static?
      lnet/selftest/conctl.c:812:1: warning: symbol 'lstcon_ioctl_entry' was not declared. Should it be static?
      lnet/selftest/module.c:92:1: warning: symbol 'lnet_selftest_structure_assertion' was not declared. Should it be static?
      lustre/fid/fid_store.c:67:6: warning: symbol 'seq_update_cb' was not declared. Should it be static?
      lustre/fid/fid_store.c:80:5: warning: symbol 'seq_update_cb_add' was not declared. Should it be static?
      lustre/fid/lproc_fid.c:346:23: warning: symbol 'fldb_sops' was not declared. Should it be static?
      lustre/fid/lproc_fid.c:502:30: warning: symbol 'seq_fld_proc_seq_fops' was not declared. Should it be static?
      lustre/fld/lproc_fld.c:272:23: warning: symbol 'fldb_sops' was not declared. Should it be static?
      lustre/lfsck/lfsck_layout.c:5547:35: warning: symbol 'lfsck_layout_assistant_ops' was not declared. Should it be static?
      lustre/lfsck/lfsck_namespace.c:6303:35: warning: symbol 'lfsck_namespace_assistant_ops' was not declared. Should it be static?
      lustre/lmv/lmv_obd.c:139:17: warning: symbol 'lmv_get_uuid' was not declared. Should it be static?
      lustre/lmv/lmv_obd.c:1652:21: warning: symbol 'lmv_locate_target_for_name' was not declared. Should it be static?
      lustre/lmv/lmv_obd.c:1749:5: warning: symbol 'lmv_create' was not declared. Should it be static?
      lustre/lmv/lmv_obd.c:2498:5: warning: symbol 'lmv_read_page' was not declared. Should it be static?
      lustre/lmv/lmv_obd.c:2810:5: warning: symbol 'lmv_set_info_async' was not declared. Should it be static?
      lustre/lmv/lmv_obd.c:3005:5: warning: symbol 'lmv_set_lock_data' was not declared. Should it be static?
      lustre/lmv/lmv_obd.c:3019:16: warning: symbol 'lmv_lock_match' was not declared. Should it be static?
      lustre/lmv/lmv_obd.c:3062:5: warning: symbol 'lmv_get_lustre_md' was not declared. Should it be static?
      lustre/lmv/lmv_obd.c:3075:5: warning: symbol 'lmv_free_lustre_md' was not declared. Should it be static?
      lustre/lmv/lmv_obd.c:3091:5: warning: symbol 'lmv_set_open_replay_data' was not declared. Should it be static?
      lustre/lmv/lmv_obd.c:3107:5: warning: symbol 'lmv_clear_open_replay_data' was not declared. Should it be static?
      lustre/lmv/lmv_obd.c:3143:5: warning: symbol 'lmv_intent_getattr_async' was not declared. Should it be static?
      lustre/lmv/lmv_obd.c:315:5: warning: symbol 'lmv_connect_mdc' was not declared. Should it be static?
      lustre/lmv/lmv_obd.c:3182:5: warning: symbol 'lmv_revalidate_lock' was not declared. Should it be static?
      lustre/lmv/lmv_obd.c:3203:5: warning: symbol 'lmv_get_fid_from_lsm' was not declared. Should it be static?
      lustre/lmv/lmv_obd.c:3224:5: warning: symbol 'lmv_quotactl' was not declared. Should it be static?
      lustre/lmv/lmv_obd.c:3315:16: warning: symbol 'lmv_obd_ops' was not declared. Should it be static?
      lustre/lmv/lmv_obd.c:3332:15: warning: symbol 'lmv_md_ops' was not declared. Should it be static?
      lustre/lod/lod_dev.c:177:19: warning: symbol 'lod_txn_callback_kmem' was not declared. Should it be static?
      lustre/lod/lod_pool.c:431:6: warning: symbol 'lod_dump_pool' was not declared. Should it be static?
      lustre/lov/lov_object.c:1545:5: warning: symbol 'lov_read_and_clear_async_rc' was not declared. Should it be static?
      lustre/lov/lov_pack.c:236:22: warning: symbol 'lov_lsm_alloc' was not declared. Should it be static?
      lustre/mdd/mdd_device.c:510:5: warning: symbol 'mdd_changelog_write_header' was not declared. Should it be static?
      lustre/mgc/mgc_request.c:398:1: warning: symbol 'llog_process_lock' was not declared. Should it be static?
      lustre/mgs/mgs_fs.c:104:5: warning: symbol 'mgs_client_add' was not declared. Should it be static?
      lustre/obdclass/linux/linux-module.c:77:5: warning: symbol 'proc_version' was not declared. Should it be static?
      lustre/obdclass/llog_osd.c:1295:18: warning: symbol 'llog_osd_get_regular_fid_dir' was not declared. Should it be static?
      lustre/obdclass/llog_swab.c:106:6: warning: symbol 'lustre_swab_llogd_conn_body' was not declared. Should it be static?
      lustre/obdclass/llog_swab.c:115:6: warning: symbol 'lustre_swab_ll_fid' was not declared. Should it be static?
      lustre/obdclass/llog_swab.c:122:6: warning: symbol 'lustre_swab_lu_seq_range' was not declared. Should it be static?
      lustre/obdclass/llog_swab.c:131:6: warning: symbol 'lustre_swab_update_ops' was not declared. Should it be static?
      lustre/obdclass/llog_swab.c:146:6: warning: symbol 'lustre_swab_llog_rec' was not declared. Should it be static?
      lustre/obdclass/llog_swab.c:339:6: warning: symbol 'lustre_swab_llog_hdr' was not declared. Should it be static?
      lustre/obdclass/llog_swab.c:374:6: warning: symbol 'lustre_swab_lustre_cfg' was not declared. Should it be static?
      lustre/obdclass/llog_swab.c:416:6: warning: symbol 'lustre_swab_cfg_marker' was not declared. Should it be static?
      lustre/obdclass/llog_swab.c:63:6: warning: symbol 'lustre_swab_lu_fid' was not declared. Should it be static?
      lustre/obdclass/llog_swab.c:71:6: warning: symbol 'lustre_swab_ost_id' was not declared. Should it be static?
      lustre/obdclass/llog_swab.c:83:6: warning: symbol 'lustre_swab_llog_id' was not declared. Should it be static?
      lustre/obdclass/llog_swab.c:90:6: warning: symbol 'lustre_swab_llogd_body' was not declared. Should it be static?
      lustre/obdclass/local_storage.c:121:18: warning: symbol 'ls_find_dev' was not declared. Should it be static?
      lustre/obdclass/lprocfs_status.c:2012:5: warning: symbol 'lprocfs_obd_rd_max_pages_per_rpc' was not declared. Should it be static?
      lustre/obdclass/lprocfs_status_server.c:232:5: warning: symbol 'lprocfs_exp_print_replydata_seq' was not declared. Should it be static?
      lustre/obdclass/lprocfs_status_server.c:251:5: warning: symbol 'lprocfs_exp_replydata_seq_show' was not declared. Should it be static?
      lustre/obdclass/lprocfs_status_server.c:45:5: warning: symbol 'lprocfs_evict_client_open' was not declared. Should it be static?
      lustre/obdclass/lprocfs_status_server.c:53:5: warning: symbol 'lprocfs_evict_client_release' was not declared. Should it be static?
      lustre/obdclass/lu_object.c:1387:1: warning: symbol 'lu_keys_guard' was not declared. Should it be static?
      lustre/obdclass/lu_object.c:2095:5: warning: symbol 'lu_printk_printer' was not declared. Should it be static?
      lustre/obdclass/lu_object.c:2106:5: warning: symbol 'lu_debugging_setup' was not declared. Should it be static?
      lustre/obdclass/lu_object.c:2111:6: warning: symbol 'lu_context_keys_dump' was not declared. Should it be static?
      lustre/obdclass/obd_config.c:1015:6: warning: symbol 'lustre_register_client_process_config' was not declared. Should it be static?
      lustre/obdclass/obd_config.c:1132:6: warning: symbol 'lustre_register_quota_process_config' was not declared. Should it be static?
      lustre/osd-zfs/osd_handler.c:1335:5: warning: symbol 'osd_fid_alloc' was not declared. Should it be static?
      lustre/osd-zfs/osd_handler.c:75:19: warning: symbol 'osd_object_kmem' was not declared. Should it be static?
      lustre/osd-zfs/osd_index.c:1638:34: warning: symbol 'osd_zfs_otable_ops' was not declared. Should it be static?
      lustre/osd-zfs/osd_index.c:493:19: warning: symbol 'osd_object_find' was not declared. Should it be static?
      lustre/osd-zfs/osd_io.c:924:27: warning: symbol 'osd_body_ops' was not declared. Should it be static?
      lustre/osd-zfs/osd_object.c:1199:5: warning: symbol '__osd_attr_init' was not declared. Should it be static?
      lustre/osd-zfs/osd_object.c:186:5: warning: symbol '__osd_object_attr_get' was not declared. Should it be static?
      lustre/osd-zfs/osd_object.c:330:5: warning: symbol 'osd_object_init0' was not declared. Should it be static?
      lustre/osd-zfs/osd_oi.c:237:5: warning: symbol 'fid_is_on_ost' was not declared. Should it be static?
      lustre/osd-zfs/osd_oi.c:72:14: warning: symbol 'osd_oi_count' was not declared. Should it be static?
      lustre/osd-zfs/osd_xattr.c:227:5: warning: symbol '__osd_xattr_get' was not declared. Should it be static?
      lustre/osp/osp_md_object.c:962:5: warning: symbol 'osp_md_declare_object_destroy' was not declared. Should it be static?
      lustre/osp/osp_md_object.c:983:5: warning: symbol 'osp_md_object_destroy' was not declared. Should it be static?
      lustre/osp/osp_object.c:1530:5: warning: symbol 'osp_declare_object_destroy' was not declared. Should it be static?
      lustre/osp/osp_object.c:2024:5: warning: symbol 'osp_orphan_it_load' was not declared. Should it be static?
      lustre/osp/osp_sync.c:438:5: warning: symbol 'osp_sync_gap' was not declared. Should it be static?
      lustre/osp/osp_trans.c:262:5: warning: symbol 'osp_prep_inline_update_req' was not declared. Should it be static?
      lustre/ost/ost_handler.c:50:5: warning: symbol 'oss_max_threads' was not declared. Should it be static?
      lustre/ptlrpc/gss/gss_krb5_mech.c:1893:5: warning: symbol 'gss_display_kerberos' was not declared. Should it be static?
      lustre/ptlrpc/gss/gss_null_mech.c:140:5: warning: symbol 'gss_display_null' was not declared. Should it be static?
      lustre/ptlrpc/gss/gss_sk_mech.c:165:5: warning: symbol 'gss_display_sk' was not declared. Should it be static?
      lustre/ptlrpc/gss/gss_svc_upcall.c:782:6: warning: symbol 'gss_secsvc_flush' was not declared. Should it be static?
      lustre/ptlrpc/layout.c:2067:6: warning: symbol '__req_capsule_dump' was not declared. Should it be static?
      lustre/ptlrpc/../../lustre/ldlm/ldlm_lib.c:2569:6: warning: symbol 'target_recovery_fini' was not declared. Should it be static?
      lustre/ptlrpc/../../lustre/ldlm/ldlm_lib.c:2590:6: warning: symbol 'target_recovery_init' was not declared. Should it be static?
      lustre/ptlrpc/../../lustre/target/out_lib.c:91:5: warning: symbol 'out_update_header_pack' was not declared. Should it be static?
      lustre/ptlrpc/../../lustre/target/tgt_handler.c:1107:5: warning: symbol 'tgt_obd_log_cancel' was not declared. Should it be static?
      lustre/ptlrpc/nodemap_handler.c:1126:6: warning: symbol 'nodemap_config_cleanup' was not declared. Should it be static?
      lustre/ptlrpc/nodemap_handler.c:1244:6: warning: symbol 'nodemap_mod_exit' was not declared. Should it be static?
      lustre/ptlrpc/nodemap_handler.c:1253:5: warning: symbol 'nodemap_mod_init' was not declared. Should it be static?
      lustre/ptlrpc/nodemap_lproc.c:1021:30: warning: symbol 'nodemap_ranges_fops' was not declared. Should it be static?
      lustre/ptlrpc/nodemap_lproc.c:1028:30: warning: symbol 'nodemap_idmap_fops' was not declared. Should it be static?
      lustre/ptlrpc/nodemap_lproc.c:1035:30: warning: symbol 'nodemap_exports_fops' was not declared. Should it be static?
      lustre/ptlrpc/pack_generic.c:2295:6: warning: symbol 'dump_obdo' was not declared. Should it be static?
      lustre/ptlrpc/wiretest.c:49:6: warning: symbol 'lustre_assert_wire_constants' was not declared. Should it be static?
      lustre/quota/lproc_quota.c:247:23: warning: symbol 'lprocfs_quota_seq_sops' was not declared. Should it be static?
      lustre/quota/lquota_lib.c:41:22: warning: symbol 'lquota_caches' was not declared. Should it be static?
      lustre/quota/qmt_dev.c:416:16: warning: symbol 'qmt_obd_ops' was not declared. Should it be static?
      lustre/quota/qsd_lib.c:57:19: warning: symbol 'upd_kmem' was not declared. Should it be static?
      lustre/quota/qsd_lib.c:59:22: warning: symbol 'qsd_caches' was not declared. Should it be static?
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                wc-triage WC Triage
                Reporter:
                green Oleg Drokin
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: