[LU-8304] libcfs_debug_dumplog calls potentially sleeping function in wrong state

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.14.0
• Severity: 3
• Assignee: Oleg Drokin
• Reporter: Oleg Drokin

Description

libcfs_debug_dumplog() sets task state to INTERRUPTIBLE and then calls kthread_run() that might sleep.

It's mostly harmless here, but still should be avoided as the kernel prints a nastygram about it when it happens.

I guess just moving the state setting to after kthread_run call is all that's needed.

Issue Links

• is related to: LU-13253 sanity/177 leaves threads blocked in libcfs_debug_dumplog()
• is related to: LU-9859 libcfs simplification

Comments

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/37398/
Subject: LU-8304 libcfs: convert debug_ctlwq to a completion.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: acb6ee1f1fbeebad43a3d415bfcf47edd05c2aba

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/37398
Subject: LU-8304 libcfs: convert debug_ctlwq to a completion.
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 7da0642bf721b43fe1bc9d67e12fdea8f537fdfc

[Gerrit Updater]

Oleg Drokin ([e-mail]) uploaded a new patch: http://review.whamcloud.com/20876
Subject: LU-8304 libcfs: Do not call kthread_run in wrong state
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 2939b69711fb3a2a1eeed996795c2a179a5b25c8