Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-8304

libcfs_debug_dumplog calls potentially sleeping function in wrong state

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.14.0
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      libcfs_debug_dumplog() sets task state to INTERRUPTIBLE and then calls kthread_run() that might sleep.

      It's mostly harmless here, but still should be avoided as the kernel prints a nastygram about it when it happens.

      I guess just moving the state setting to after kthread_run call is all that's needed.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-13253 sanity/177 leaves threads blocked in libcfs_debug_dumplog()

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is related to

          Improvement - An improvement or enhancement to an existing feature or task. LU-9859 libcfs simplification

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Activity

            [LU-8304] libcfs_debug_dumplog calls potentially sleeping function in wrong state
            simmonsja James A Simmons made changes -
            Fix Version/s New: Lustre 2.14.0 [ 14490 ]
            Resolution New: Fixed [ 1 ]
            Status Original: Open [ 1 ] New: Closed [ 6 ]
            simmonsja James A Simmons made changes -
            Link New: This issue is related to LU-13253 [ LU-13253 ]
            gerrit Gerrit Updater added a comment -

            Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/37398/
            Subject: LU-8304 libcfs: convert debug_ctlwq to a completion.
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: acb6ee1f1fbeebad43a3d415bfcf47edd05c2aba

            gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/37398/ Subject: LU-8304 libcfs: convert debug_ctlwq to a completion. Project: fs/lustre-release Branch: master Current Patch Set: Commit: acb6ee1f1fbeebad43a3d415bfcf47edd05c2aba
            gerrit Gerrit Updater added a comment -

            James Simmons (jsimmons@infradead.org) uploaded a new patch: https://review.whamcloud.com/37398
            Subject: LU-8304 libcfs: convert debug_ctlwq to a completion.
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 7da0642bf721b43fe1bc9d67e12fdea8f537fdfc

            gerrit Gerrit Updater added a comment - James Simmons (jsimmons@infradead.org) uploaded a new patch: https://review.whamcloud.com/37398 Subject: LU-8304 libcfs: convert debug_ctlwq to a completion. Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 7da0642bf721b43fe1bc9d67e12fdea8f537fdfc
            simmonsja James A Simmons made changes -
            Link New: This issue is related to LU-9859 [ LU-9859 ]
            green Oleg Drokin made changes -
            Assignee Original: WC Triage [ wc-triage ] New: Oleg Drokin [ green ]
            gerrit Gerrit Updater added a comment -

            Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: http://review.whamcloud.com/20876
            Subject: LU-8304 libcfs: Do not call kthread_run in wrong state
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 2939b69711fb3a2a1eeed996795c2a179a5b25c8

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: http://review.whamcloud.com/20876 Subject: LU-8304 libcfs: Do not call kthread_run in wrong state Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 2939b69711fb3a2a1eeed996795c2a179a5b25c8
            green Oleg Drokin created issue -

            People

              green Oleg Drokin
              green Oleg Drokin
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: