Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-8371

Optimize open of known negative dentry

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.9.0
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      While working with Al Viro on some corner cases in atomic open, I noticed that we are doing a lot more work than necessary there.

      If we were called with a negative dentry - that means just now we revalidated that dentry so there's no point in contacting MDS to open that file (unless it's a create request), we can just return ENOENT and be done with it which speeds up 99.9% of all usecases and the remaining 0.15 where it's a valid race, we just resolve it the other way as is perfectly fine for us to do.

      Attachments

        Activity

          [LU-8371] Optimize open of known negative dentry
          pjones Peter Jones added a comment -

          Landed for 2.9

          pjones Peter Jones added a comment - Landed for 2.9

          Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/21168/
          Subject: LU-8371 llite: Trust creates in revalidate too.
          Project: fs/lustre-release
          Branch: master
          Current Patch Set:
          Commit: 9573911bfb4a2c3d7e2047c9d5f5440d9c7e7db5

          gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/21168/ Subject: LU-8371 llite: Trust creates in revalidate too. Project: fs/lustre-release Branch: master Current Patch Set: Commit: 9573911bfb4a2c3d7e2047c9d5f5440d9c7e7db5

          Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/21161/
          Subject: LU-8371 llite: optimize atomic_open of negative dentry.
          Project: fs/lustre-release
          Branch: master
          Current Patch Set:
          Commit: 7334a2d33cc4cf4cda0c81b126c4cb8ab28a888d

          gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/21161/ Subject: LU-8371 llite: optimize atomic_open of negative dentry. Project: fs/lustre-release Branch: master Current Patch Set: Commit: 7334a2d33cc4cf4cda0c81b126c4cb8ab28a888d

          Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: http://review.whamcloud.com/21168
          Subject: LU-8371 llite: Trust creates in revalidate too.
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 2852d1a30a7778c233b22ad477e85ff75e5097d0

          gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: http://review.whamcloud.com/21168 Subject: LU-8371 llite: Trust creates in revalidate too. Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 2852d1a30a7778c233b22ad477e85ff75e5097d0

          Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: http://review.whamcloud.com/21161
          Subject: LU-8371: llite: optimize atomic_open of negative dentry.
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 34867f1a3a4f8f2cbb622b0b5b4ccbd88f679249

          gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: http://review.whamcloud.com/21161 Subject: LU-8371 : llite: optimize atomic_open of negative dentry. Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 34867f1a3a4f8f2cbb622b0b5b4ccbd88f679249

          People

            green Oleg Drokin
            green Oleg Drokin
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: