Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.9.0, Lustre 2.10.0
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      There are several unused but set variables. A few represent real bugs and some others are addressed under other issues. Here is a list I collected last week:

      /root/lustre-release/ldiskfs/inode.c:3352: warning: variable ‘to’ set but not used
      /root/lustre-release/ldiskfs/inode.c:6189: warning: variable ‘entry’ set but not used
      /root/lustre-release/ldiskfs/inode.c:6479: warning: variable ‘blocksize’ set but not used
      /root/lustre-release/ldiskfs/mballoc.c:1966: warning: variable ‘bsbits’ set but not used
      /root/lustre-release/ldiskfs/mballoc.c:2965: warning: variable ‘orig_size’ set but not used
      /root/lustre-release/ldiskfs/mballoc.c:2966: warning: variable ‘orig_start’ set but not used
      /root/lustre-release/ldiskfs/mballoc.c:3710: warning: variable ‘start’ set but not used
      /root/lustre-release/ldiskfs/mballoc.c:4899: warning: variable ‘es’ set but not used
      /root/lustre-release/ldiskfs/mballoc.c:4904: warning: variable ‘grp’ set but not used
      /root/lustre-release/ldiskfs/move_extent.c:478: warning: variable ‘new_phys_end’ set but not used
      /root/lustre-release/ldiskfs/namei.c:1475: warning: variable ‘inode’ set but not used
      /root/lustre-release/ldiskfs/resize.c:945: warning: variable ‘o_groups_count’ set but not used
      /root/lustre-release/ldiskfs/super.c:4516: warning: variable ‘resv_blocks’ set but not used
      
      /root/lustre-release/lnet/lnet/nidstrings.c:252: warning: variable ‘tmp’ set but not used
      
      /root/lustre-release/lustre/fid/lproc_fid.c:71: warning: variable ‘rc’ set but not used
      /root/lustre-release/lustre/mdd/mdd_dir.c:3642: warning: variable ‘recsize’ set but not used
      /root/lustre-release/lustre/mdt/mdt_coordinator.c:1524: warning: variable ‘hcad’ set but not used
      /root/lustre-release/lustre/mdt/mdt_coordinator.c:875: warning: variable ‘ptr’ set but not used
      /root/lustre-release/lustre/mdt/mdt_hsm_cdt_actions.c:366: warning: variable ‘count’ set but not used
      /root/lustre-release/lustre/mgs/lproc_mgs.c:181: warning: variable ‘rc’ set but not used
      /root/lustre-release/lustre/mgs/mgs_handler.c:1298: warning: variable ‘rc’ set but not used
      /root/lustre-release/lustre/ofd/ofd_grant.c:1078: warning: variable ‘rc’ set but not used
      /root/lustre-release/lustre/ofd/ofd_obd.c:1089: warning: variable ‘info’ set but not used
      /root/lustre-release/lustre/osc/osc_request.c:1072: warning: variable ‘err’ set but not used
      /root/lustre-release/lustre/osd-ldiskfs/osd_iam.c:1070: warning: variable ‘c’ set but not used
      /root/lustre-release/lustre/osd-ldiskfs/osd_iam.c:1411: warning: variable ‘object’ set but not used
      /root/lustre-release/lustre/osd-ldiskfs/osd_iam_lfix.c:492: warning: variable ‘result’ set but not used
      /root/lustre-release/lustre/osd-ldiskfs/osd_iam_lvar.c:743: warning: variable ‘result’ set but not used
      /root/lustre-release/lustre/osp/lwp_dev.c:364: warning: variable ‘imp’ set but not used
      /root/lustre-release/lustre/osp/osp_dev.c:1324: warning: variable ‘imp’ set but not used
      /root/lustre-release/lustre/ptlrpc/../../lustre/ldlm/ldlm_plain.c:77: warning: variable ‘tmp’ set but not used
      /root/lustre-release/lustre/ptlrpc/../../lustre/target/tgt_handler.c:1734: warning: variable ‘err’ set but not used
      /root/lustre-release/lustre/ptlrpc/../../lustre/target/update_trans.c:175: warning: variable ‘params’ set but not used
      /root/lustre-release/lustre/quota/qmt_lock.c:545: warning: variable ‘rc’ set but not used
      /root/lustre-release/lustre/quota/qmt_lock.c:605: warning: variable ‘rc’ set but not used
      /root/lustre-release/lustre/quota/qsd_lock.c:382: warning: variable ‘qsd’ set but not used
      /root/lustre-release/lustre/quota/qsd_request.c:161: warning: variable ‘lit’ set but not used
      

      Attachments

        Issue Links

          Activity

            [LU-8378] unused but set variables

            Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/23820/
            Subject: LU-8378 obd: move s3 in lmd_parse to inner loop
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 6867d7abdb9905da98d8e90b8dc65d84a7656363

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/23820/ Subject: LU-8378 obd: move s3 in lmd_parse to inner loop Project: fs/lustre-release Branch: master Current Patch Set: Commit: 6867d7abdb9905da98d8e90b8dc65d84a7656363

            James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/23820
            Subject: LU-8378 obd: move s3 in lmd_parse to inner loop
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 79f032e952a2c966366f7ea70badea5efec6d4e7

            gerrit Gerrit Updater added a comment - James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/23820 Subject: LU-8378 obd: move s3 in lmd_parse to inner loop Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 79f032e952a2c966366f7ea70badea5efec6d4e7
            pjones Peter Jones added a comment -

            Landed for 2.9

            pjones Peter Jones added a comment - Landed for 2.9

            Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/23221/
            Subject: LU-8378 all: remove set but unused variables
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: b1ff338ede34421acfc2cdbfe0dbe7b293ebd3b2

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/23221/ Subject: LU-8378 all: remove set but unused variables Project: fs/lustre-release Branch: master Current Patch Set: Commit: b1ff338ede34421acfc2cdbfe0dbe7b293ebd3b2

            Yang Sheng (yang.sheng@intel.com) uploaded a new patch: http://review.whamcloud.com/23221
            Subject: LU-8378 all: remove set but unused variables
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 561a2681d3f051621c0f4631bb9e5446e6ee3a26

            gerrit Gerrit Updater added a comment - Yang Sheng (yang.sheng@intel.com) uploaded a new patch: http://review.whamcloud.com/23221 Subject: LU-8378 all: remove set but unused variables Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 561a2681d3f051621c0f4631bb9e5446e6ee3a26
            pjones Peter Jones added a comment -

            Yang Sheng

            Could you please look into this?

            Thanks

            Peter

            pjones Peter Jones added a comment - Yang Sheng Could you please look into this? Thanks Peter

            People

              ys Yang Sheng
              jhammond John Hammond
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: