[LU-8378] unused but set variables

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.9.0, Lustre 2.10.0
• Severity: 3
• Assignee: Yang Sheng
• Reporter: John Hammond

Description

There are several unused but set variables. A few represent real bugs and some others are addressed under other issues. Here is a list I collected last week:

/root/lustre-release/ldiskfs/inode.c:3352: warning: variable ‘to’ set but not used
/root/lustre-release/ldiskfs/inode.c:6189: warning: variable ‘entry’ set but not used
/root/lustre-release/ldiskfs/inode.c:6479: warning: variable ‘blocksize’ set but not used
/root/lustre-release/ldiskfs/mballoc.c:1966: warning: variable ‘bsbits’ set but not used
/root/lustre-release/ldiskfs/mballoc.c:2965: warning: variable ‘orig_size’ set but not used
/root/lustre-release/ldiskfs/mballoc.c:2966: warning: variable ‘orig_start’ set but not used
/root/lustre-release/ldiskfs/mballoc.c:3710: warning: variable ‘start’ set but not used
/root/lustre-release/ldiskfs/mballoc.c:4899: warning: variable ‘es’ set but not used
/root/lustre-release/ldiskfs/mballoc.c:4904: warning: variable ‘grp’ set but not used
/root/lustre-release/ldiskfs/move_extent.c:478: warning: variable ‘new_phys_end’ set but not used
/root/lustre-release/ldiskfs/namei.c:1475: warning: variable ‘inode’ set but not used
/root/lustre-release/ldiskfs/resize.c:945: warning: variable ‘o_groups_count’ set but not used
/root/lustre-release/ldiskfs/super.c:4516: warning: variable ‘resv_blocks’ set but not used

/root/lustre-release/lnet/lnet/nidstrings.c:252: warning: variable ‘tmp’ set but not used

/root/lustre-release/lustre/fid/lproc_fid.c:71: warning: variable ‘rc’ set but not used
/root/lustre-release/lustre/mdd/mdd_dir.c:3642: warning: variable ‘recsize’ set but not used
/root/lustre-release/lustre/mdt/mdt_coordinator.c:1524: warning: variable ‘hcad’ set but not used
/root/lustre-release/lustre/mdt/mdt_coordinator.c:875: warning: variable ‘ptr’ set but not used
/root/lustre-release/lustre/mdt/mdt_hsm_cdt_actions.c:366: warning: variable ‘count’ set but not used
/root/lustre-release/lustre/mgs/lproc_mgs.c:181: warning: variable ‘rc’ set but not used
/root/lustre-release/lustre/mgs/mgs_handler.c:1298: warning: variable ‘rc’ set but not used
/root/lustre-release/lustre/ofd/ofd_grant.c:1078: warning: variable ‘rc’ set but not used
/root/lustre-release/lustre/ofd/ofd_obd.c:1089: warning: variable ‘info’ set but not used
/root/lustre-release/lustre/osc/osc_request.c:1072: warning: variable ‘err’ set but not used
/root/lustre-release/lustre/osd-ldiskfs/osd_iam.c:1070: warning: variable ‘c’ set but not used
/root/lustre-release/lustre/osd-ldiskfs/osd_iam.c:1411: warning: variable ‘object’ set but not used
/root/lustre-release/lustre/osd-ldiskfs/osd_iam_lfix.c:492: warning: variable ‘result’ set but not used
/root/lustre-release/lustre/osd-ldiskfs/osd_iam_lvar.c:743: warning: variable ‘result’ set but not used
/root/lustre-release/lustre/osp/lwp_dev.c:364: warning: variable ‘imp’ set but not used
/root/lustre-release/lustre/osp/osp_dev.c:1324: warning: variable ‘imp’ set but not used
/root/lustre-release/lustre/ptlrpc/../../lustre/ldlm/ldlm_plain.c:77: warning: variable ‘tmp’ set but not used
/root/lustre-release/lustre/ptlrpc/../../lustre/target/tgt_handler.c:1734: warning: variable ‘err’ set but not used
/root/lustre-release/lustre/ptlrpc/../../lustre/target/update_trans.c:175: warning: variable ‘params’ set but not used
/root/lustre-release/lustre/quota/qmt_lock.c:545: warning: variable ‘rc’ set but not used
/root/lustre-release/lustre/quota/qmt_lock.c:605: warning: variable ‘rc’ set but not used
/root/lustre-release/lustre/quota/qsd_lock.c:382: warning: variable ‘qsd’ set but not used
/root/lustre-release/lustre/quota/qsd_request.c:161: warning: variable ‘lit’ set but not used

Issue Links

• is duplicated by: LU-8671 bad error handling in mgs_object_init
• is related to: LU-7950 Suspicious dereference of pointer before NULL check in lwp_device_fini()
• is related to: LU-8354 soft lockup in ldlm_plain_compat_queue