Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-7950

Suspicious dereference of pointer before NULL check in lwp_device_fini()

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.9.0
    • None
    • 3
    • 9223372036854775807

    Description

      Suspicious dereference of pointer 'm->lpd_obd' before NULL check at line 377

      • An event which alters the program's state, leading to the defect
        lwp_dev.c:375: 'm->lpd_obd' is dereferenced.
      • An event which alters the program's state, leading to the defect
        lwp_dev.c:377: 'm->lpd_obd' is checked for NULL.
      375			imp = m->lpd_obd->u.cli.cl_import;
      376		 
      377			LASSERT(m->lpd_obd);
      

      Attachments

        Issue Links

          Activity

            [LU-7950] Suspicious dereference of pointer before NULL check in lwp_device_fini()
            pjones Peter Jones added a comment -

            Landed for 2.9

            pjones Peter Jones added a comment - Landed for 2.9

            Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/21024/
            Subject: LU-7950 osp: Remove assigned but not used variable
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 107c1d022ffd976b4a335f794de731cf9d57a514

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/21024/ Subject: LU-7950 osp: Remove assigned but not used variable Project: fs/lustre-release Branch: master Current Patch Set: Commit: 107c1d022ffd976b4a335f794de731cf9d57a514

            Arshad Hussain (arshad.super@gmail.com) uploaded a new patch: http://review.whamcloud.com/21066
            Subject: LU-7950 osp: Remove assigned but not used variable
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 58c45164de896ac6eae8c09fb38f8f40e399f125

            gerrit Gerrit Updater added a comment - Arshad Hussain (arshad.super@gmail.com) uploaded a new patch: http://review.whamcloud.com/21066 Subject: LU-7950 osp: Remove assigned but not used variable Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 58c45164de896ac6eae8c09fb38f8f40e399f125
            pjones Peter Jones added a comment -

            Dmitry

            Could you please review this patch when you are back in the office?

            Thanks

            Peter

            pjones Peter Jones added a comment - Dmitry Could you please review this patch when you are back in the office? Thanks Peter

            Arshad Hussain (arshad.super@gmail.com) uploaded a new patch: http://review.whamcloud.com/21024
            Subject: LU-7950 osp: Move assignment below LASSERT()
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: db6494631db78f0984f149361e6caf963c059619

            gerrit Gerrit Updater added a comment - Arshad Hussain (arshad.super@gmail.com) uploaded a new patch: http://review.whamcloud.com/21024 Subject: LU-7950 osp: Move assignment below LASSERT() Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: db6494631db78f0984f149361e6caf963c059619

            the same in osp_device_fini():
            Suspicious dereference of pointer 'osp->opd_obd' before NULL check at line 1341

            dmiter Dmitry Eremin (Inactive) added a comment - the same in osp_device_fini(): Suspicious dereference of pointer 'osp->opd_obd' before NULL check at line 1341

            People

              dmiter Dmitry Eremin (Inactive)
              dmiter Dmitry Eremin (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: