Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-8400

Remove OBD_IOC_GET_MNTOPT ioctl as it's only used to pass info between mdd and mdt

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.11.0
    • None
    • 3
    • 9223372036854775807

    Description

      The OBD_IOC_GET_MNTOPT ioctl should be removed because it's not actually usable in user-space and is only used by kernel in mdd and mdt to pass information.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-8330 Incorrect ioctl definitions declaring a pointer to buffer instead of buffer argument.

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • In Progress

          Activity

            [LU-8400] Remove OBD_IOC_GET_MNTOPT ioctl as it's only used to pass info between mdd and mdt
            pjones Peter Jones made changes -
            Fix Version/s New: Lustre 2.11.0 [ 13091 ]
            Resolution New: Fixed [ 1 ]
            Status Original: Open [ 1 ] New: Resolved [ 5 ]
            pjones Peter Jones added a comment -

            Landed for 2.11

            pjones Peter Jones added a comment - Landed for 2.11
            gerrit Gerrit Updater added a comment -

            Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/28777/
            Subject: LU-8400 mdd: remove OBD_IOC_GET_MNTOPT
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 20ffe2191c828d3e4922429f2a98584d4e41eb53

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/28777/ Subject: LU-8400 mdd: remove OBD_IOC_GET_MNTOPT Project: fs/lustre-release Branch: master Current Patch Set: Commit: 20ffe2191c828d3e4922429f2a98584d4e41eb53
            hdoreau Henri Doreau (Inactive) made changes -
            Assignee Original: WC Triage [ wc-triage ] New: Henri Doreau [ hdoreau ]
            gerrit Gerrit Updater added a comment -

            Henri Doreau (henri.doreau@cea.fr) uploaded a new patch: https://review.whamcloud.com/28777
            Subject: LU-8400 mdd: remove OBD_IOC_GET_MNTOPT
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 5f60a895cc976f8df9cdd7dc7883eb5b4bb60511

            gerrit Gerrit Updater added a comment - Henri Doreau (henri.doreau@cea.fr) uploaded a new patch: https://review.whamcloud.com/28777 Subject: LU-8400 mdd: remove OBD_IOC_GET_MNTOPT Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 5f60a895cc976f8df9cdd7dc7883eb5b4bb60511
            hdoreau Henri Doreau (Inactive) added a comment -

            BTW I realized that another ioctl had opcode 220... good time to remove it.

            hdoreau Henri Doreau (Inactive) added a comment - BTW I realized that another ioctl had opcode 220... good time to remove it.
            adilger Andreas Dilger added a comment -

            It appears that both OBD_IOC_GET_MNTOPT and mdd_maxeasize_get() should either be replaced by a single mdd_dtconf_get() method that returns struct dt_device_param to the caller, or GET_MNTOPT should be replaced by a new mdd_mntopt_get() method for consistency. In either case the OBD_IOC_GET_MNTOPT definition should be removed, though a stub should be left behind, like:

             /*   was   OBD_IOC_GET_MNTOPT      _IOW ('f', 220, mntopt_t) until 2.9 */
            adilger Andreas Dilger added a comment - It appears that both OBD_IOC_GET_MNTOPT and mdd_maxeasize_get() should either be replaced by a single mdd_dtconf_get() method that returns struct dt_device_param to the caller, or GET_MNTOPT should be replaced by a new mdd_mntopt_get() method for consistency. In either case the OBD_IOC_GET_MNTOPT definition should be removed, though a stub should be left behind, like: /* was OBD_IOC_GET_MNTOPT _IOW ( 'f' , 220, mntopt_t) until 2.9 */
            adilger Andreas Dilger made changes -
            Labels New: easy
            utopiabound Nathaniel Clark made changes -
            Link New: This issue is related to LU-8330 [ LU-8330 ]
            utopiabound Nathaniel Clark created issue -

            People

              hdoreau Henri Doreau (Inactive)
              utopiabound Nathaniel Clark
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: