[LU-8403] OBD_NOTIFY_* flags cleanup

• Type: Improvement
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.10.0
• Labels: easy
• Assignee: John Hammond
• Reporter: John Hammond

Description

Half of the OBD_NOTIFY_* flags are essentially useless but we still have code that used them. The useless ones are

OBD_NOTIFY_CREATE
OBD_NOTIFY_CONNECT
OBD_NOTIFY_SYNC_NONBLOCK
OBD_NOTIFY_SYNC
OBD_NOTIFY_CONFIG

1. Server side OBDs do not implement o_notify and so the OBD_NOTIFY_CONFIG notification in server_start_targets() is useless and can be removed.
2. The data parameter of obd_notify() and obd_notify_observer() may be removed.
3. lov_notify() may be simplified by assuming that watched is not NULL.
4. The OBD_NOTIFY_CONNECT notification in lov_connect() is useless and can be removed.
5. The OBD_NOTIFY_ACTIVE notification in lmv_connect_mdc() is useless and can be rremoved.
6. lco_flags is never checked in llite and can be removed.
7. enum config_flags can be removed.