Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-8543

ll_revalidate_dentry unsafe usage of parent inode

Details

    • Bug
    • Resolution: Unresolved
    • Major
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      Al Viro advises us that we cannot just use parent inode like that unguarded.

      There are two problems.
      First, by the time we get to ll_Revalidate, the parent might change since nothing locks it, but there's nothing we could do about it.
      But the other problem - the parent inode could be freed while we are there and we do not hold a reference - so this should be fixed.
      We should convert to something like dget_parent.

      Attachments

        Activity

          [LU-8543] ll_revalidate_dentry unsafe usage of parent inode
          adilger Andreas Dilger made changes -
          Labels New: patch

          Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: https://review.whamcloud.com/24176
          Subject: LU-8543 llite: Use dget_parent to safely access parent in revalidate
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 8f101693f988d9d053e9daca5c02f972d68332d1

          gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: https://review.whamcloud.com/24176 Subject: LU-8543 llite: Use dget_parent to safely access parent in revalidate Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 8f101693f988d9d053e9daca5c02f972d68332d1
          cheneva1 Evan D. Chen (Inactive) made changes -
          Assignee Original: WC Triage [ wc-triage ] New: Oleg Drokin [ green ]
          green Oleg Drokin created issue -

          People

            green Oleg Drokin
            green Oleg Drokin
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated: