[LU-8561] Redundant check in osd_mount

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.9.0
• Severity: 3
• Assignee: Jinshan Xiong (Inactive)
• Reporter: Oleg Drokin

Description

smatch reports that:

1030	1030	 err:
1031	1031	 »       if (rc) {
1032	1032	 »       »       if (o->od_os)
Misc Code Checks Robot (Gatekeeper helper)	warn: osd_mount():variable dereferenced before check 'o->od_os' (see line …

Basically the problem here is o->od_os is always true.

While it's possible to convert this to LASSERT, I wonder if we should just drop it altogether since there'd be crash either way.

This was exposed by landing of LU-4865 patch, even though the problem actually was there before it

Comments

[Peter Jones]

Landed for 2.9

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/22245/
Subject: LU-8561 osd-zfs: make smatch happy
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 6c747f6cc18e0e89d3d90e9c8f0de1994776871f

[Gerrit Updater]

Jinshan Xiong ([e-mail]) uploaded a new patch: http://review.whamcloud.com/22245
Subject: LU-8561 osd-zfs: make smatch happy
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: a6e4d1c85091537e5bfbd650e5b6fa2b997f4769