Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-8632

Address of function 'page_count' is used instead of a local variable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: Lustre 2.9.0
    • Labels:
    • Severity:
      3
    • Rank (Obsolete):
      9223372036854775807

      Description

      In the following commit

      commit 7f2aae8d80a73de7408668bbe569d5f4d8553efe
      Author: Jinshan Xiong <jinshan.xiong@intel.com>
      Date:   Mon Sep 12 11:17:10 2016 -0700
      
          LU-8135 osc: limits the number of chunks in write RPC
          
          OSC has to make sure that it won't issue write RPCs with too many
          chunks otherwise it will casue ZFS to create transactions much
          bigger than DMU_MAX_ACCESS in size, which will end up with write
          failure.
          
          Signed-off-by: Jinshan Xiong <jinshan.xiong@intel.com>
          Change-Id: Ib68b09afca35c253ef0a6b569f64f555e08bd11b
          Reviewed-on: http://review.whamcloud.com/22369
          Tested-by: Jenkins
          Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
          Reviewed-by: Patrick Farrell <paf@cray.com>
          Tested-by: Maloo <hpdd-maloo@intel.com>
          Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
      

      the local variable 'page_count' in osc_send_read_rpc() was removed:

      -       unsigned int page_count = 0;
      

      but ASSERT with this variable was not:

      2171:	LASSERT(page_count > 0);
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                dmiter Dmitry Eremin (Inactive)
                Reporter:
                dmiter Dmitry Eremin (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: