Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-8697

remove IS_ERR(master_inode) check.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: Lustre 2.9.0
    • Labels:
      None
    • Severity:
      3
    • Rank (Obsolete):
      9223372036854775807

      Description

      The patch 2de353860782: "staging: lustre: create striped directory"
      from Aug 16, 2016, leads to the following static checker warning:

      drivers/staging/lustre/lustre/llite/namei.c:294 ll_md_blocking_ast()
      warn: 'master_inode' isn't an ERR_PTR

      drivers/staging/lustre/lustre/llite/namei.c
      287
      288 hash =
      cl_fid_build_ino(&lli->lli_pfid,
      289
      ll_need_32bit_api(ll_i2sbi(inode)));
      290
      291 master_inode =
      ilookup5(inode->i_sb, hash,
      292
      ll_test_inode_by_fid,
      293 (void
      *)&lli->lli_pfid);
      294 if (master_inode &&
      !IS_ERR(master_inode)) {

      ^^^^^^^^^^^^^^^^^^^^
      ilookup5() never returns ERR_PTRs.

        Attachments

          Activity

            People

            • Assignee:
              simmonsja James A Simmons
              Reporter:
              di.wang Di Wang
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: