Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-8700

dkms fails to build lustre on Power8 due to llite_loop missing

Details

    • Bug
    • Resolution: Fixed
    • Major
    • Lustre 2.9.0
    • Lustre 2.8.0, Lustre 2.9.0
    • None
    • Power8 clients running RHEL7.
    • 3
    • 9223372036854775807

    Description

      On the Power8 platform the llite_loop device is not built but the dkms spec files expect that the llite_loop.ko is present. This causes lustre to fail to install using dkms on Power8 clients.

      Attachments

        Issue Links

          Activity

            [LU-8700] dkms fails to build lustre on Power8 due to llite_loop missing
            pjones Peter Jones added a comment -

            Landed for 2.9

            pjones Peter Jones added a comment - Landed for 2.9

            Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/23228/
            Subject: LU-8700 build: dkms do not install llite_lloop
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 21bed01ff234a239e4b044b099d53ba2fe7ca24a

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/23228/ Subject: LU-8700 build: dkms do not install llite_lloop Project: fs/lustre-release Branch: master Current Patch Set: Commit: 21bed01ff234a239e4b044b099d53ba2fe7ca24a
            bfaccini Bruno Faccini (Inactive) added a comment - - edited

            Gerrit-change #23228 now simply always ignore llite_lloop.ko module in DKMS.

            bfaccini Bruno Faccini (Inactive) added a comment - - edited Gerrit-change #23228 now simply always ignore llite_lloop.ko module in DKMS.

            Well in fact seems that I have misunderstood llite_lloop.ko module's features/usages, and its is mostly being used for Clients as it is mainly allowing Clients to use a Lustre file as a block-device (for example as their swap-device for diskless Clients, ...).
            So I will modify my Gerrit-change #23228 to allow DKMS to build/create llite_lloop.ko module for/on both Lustre Clients and Servers, but only if their PAGE_SIZE < 65536.

            bfaccini Bruno Faccini (Inactive) added a comment - Well in fact seems that I have misunderstood llite_lloop.ko module's features/usages, and its is mostly being used for Clients as it is mainly allowing Clients to use a Lustre file as a block-device (for example as their swap-device for diskless Clients, ...). So I will modify my Gerrit-change #23228 to allow DKMS to build/create llite_lloop.ko module for/on both Lustre Clients and Servers, but only if their PAGE_SIZE < 65536.

            Faccini Bruno (bruno.faccini@intel.com) uploaded a new patch: http://review.whamcloud.com/23228
            Subject: LU-8700 build: dkms only build llite_lloop for servers
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 2380750551c03a312e5abf5b010c3d5213292e70

            gerrit Gerrit Updater added a comment - Faccini Bruno (bruno.faccini@intel.com) uploaded a new patch: http://review.whamcloud.com/23228 Subject: LU-8700 build: dkms only build llite_lloop for servers Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 2380750551c03a312e5abf5b010c3d5213292e70
            bfaccini Bruno Faccini (Inactive) added a comment - - edited

            I understand that llite_lloop.ko is not built for Power8 platform due to PAGE_SIZE == 65536, but I wonder if, due to its specific purpose/usage, it is not just/simply ok to ignore it during DKMS Client builds. On the other hand, in dkms.mkconf, do we need to find the PAGE_SIZE for the Kernel we build against (quite easy to implement) or just determine if it is a Lustre Server/Client build/package (much more easy!!) ??

            bfaccini Bruno Faccini (Inactive) added a comment - - edited I understand that llite_lloop.ko is not built for Power8 platform due to PAGE_SIZE == 65536, but I wonder if, due to its specific purpose/usage, it is not just/simply ok to ignore it during DKMS Client builds. On the other hand, in dkms.mkconf, do we need to find the PAGE_SIZE for the Kernel we build against (quite easy to implement) or just determine if it is a Lustre Server/Client build/package (much more easy!!) ??

            This should be handled in dkms.mkconf during on-target configure step. I will cook a patch to implement it.

            bfaccini Bruno Faccini (Inactive) added a comment - This should be handled in dkms.mkconf during on-target configure step. I will cook a patch to implement it.

            Since llite_loop was already removed in the upstream kernel, it makes sense just to delete it and the test(s) that reference it from master as well.

            adilger Andreas Dilger added a comment - Since llite_loop was already removed in the upstream kernel, it makes sense just to delete it and the test(s) that reference it from master as well.

            People

              bfaccini Bruno Faccini (Inactive)
              simmonsja James A Simmons
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: