[LU-8723] llapi_obd_statfs() tests errno in non error cases, may leak file descriptors

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.9.0
• Affects Version/s: Lustre 2.9.0
• Labels: easy
• Severity: 3
• Assignee: WC Triage
• Reporter: John Hammond

Description

In llapi_obd_statfs() we have:

        fd = open(path, O_RDONLY);
        if (errno == EISDIR)
                fd = open(path, O_DIRECTORY | O_RDONLY);

Second, if open() succeeds then the value of errno is arbitrary and the file descriptor may be leaked if errno was previously set to EISDIR.

Also note that open() will never set errno to EISDIR when write access is not requested.

Comments

[Peter Jones]

Landed for 2.9

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/23285/
Subject: LU-8723 llapi: correct open() handling in llapi_obd_statfs()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: c791db551d022cd804e9dcc751cd7e33102a741a

[Gerrit Updater]

John L. Hammond ([e-mail]) uploaded a new patch: http://review.whamcloud.com/23285
Subject: LU-8723 llapi: correct open() handling in llapi_obd_statfs()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: bde378b948a515b53f22feb5f32fecd628b2bbd0