[LU-8723] llapi_obd_statfs() tests errno in non error cases, may leak file descriptors

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.9.0
• Affects Version/s: Lustre 2.9.0
• Labels: easy
• Severity: 3
• Assignee: WC Triage
• Reporter: John Hammond

Description

In llapi_obd_statfs() we have:

        fd = open(path, O_RDONLY);
        if (errno == EISDIR)
                fd = open(path, O_DIRECTORY | O_RDONLY);

Second, if open() succeeds then the value of errno is arbitrary and the file descriptor may be leaked if errno was previously set to EISDIR.

Also note that open() will never set errno to EISDIR when write access is not requested.