Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-8767

Improve proc file text in lproc_llite.c

Details

    • Bug
    • Resolution: Fixed
    • Trivial
    • Lustre 2.10.0
    • None
    • 3
    • 9223372036854775807

    Description

      Several improvements were suggested in LU-8186 for the text displayed in the /proc/fs/lustre/llite/.../extents_stats* files. The relevant text occurs multiple times in lustre/llite/lproc_llite.c:

      seq_puts(seq, "disabled\n write anything in this file to activate, then 0 or \"[D/d]isabled\" to deactivate\n");
      

      The following changes should be made to all occurrences of the text:

      • Use single quotes to avoid the need for escapes.
      • Simplify the message by only mentioning "disabled" with lower case, and silently continue to accept "Disabled".
      • Use a | to separate the two options to be consistent with accepted usage.
      • Replace "in this file" with "to this file"

      Attachments

        Activity

          [LU-8767] Improve proc file text in lproc_llite.c
          pjones Peter Jones added a comment -

          Landed for 2.10

          pjones Peter Jones added a comment - Landed for 2.10

          Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/23942/
          Subject: LU-8767 llite: Improve proc file text in lproc_llite.c
          Project: fs/lustre-release
          Branch: master
          Current Patch Set:
          Commit: 8d27681c98b2e702b2d3ea7fc603e21c444f7590

          gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/23942/ Subject: LU-8767 llite: Improve proc file text in lproc_llite.c Project: fs/lustre-release Branch: master Current Patch Set: Commit: 8d27681c98b2e702b2d3ea7fc603e21c444f7590

          Steve Guminski (stephenx.guminski@intel.com) uploaded a new patch: http://review.whamcloud.com/23942
          Subject: LU-8767 llite: Improve proc file text in lproc_llite.c
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 2c5a9f92766894d10437633e59d90ccbb77bc69b

          gerrit Gerrit Updater added a comment - Steve Guminski (stephenx.guminski@intel.com) uploaded a new patch: http://review.whamcloud.com/23942 Subject: LU-8767 llite: Improve proc file text in lproc_llite.c Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 2c5a9f92766894d10437633e59d90ccbb77bc69b

          People

            sguminsx Steve Guminski (Inactive)
            sguminsx Steve Guminski (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: