Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-8841

Replace l_wait_info calls that use zeroed info parameters

    XMLWordPrintable

Details

    • Bug
    • Resolution: Duplicate
    • Minor
    • None
    • Lustre 2.9.0
    • None
    • 3
    • 9223372036854775807

    Description

      There are many cases where l_wait_event is used with an l_wait_info parameter that is completely zeroed. This is done to wait for new kernel threads to be started (or exit due to a failure). These cases should be replaced with the native wait_event or wait_event_timeout as appropriate.

      An example of the zeroed l_wait_info is in sptlrpc_gc_init:

      struct l_wait_info lwi = { 0 };
      ...
      task = kthread_run(...);
      ...
      l_wait_event(sec_gc_thread.t_ctl_waitq, thread_is_running(&sec_gc_thread), &lwi);
      
      

      This issue was uncovered during the code review at http://review.whamcloud.com/#/c/23754/

      Attachments

        Issue Links

          Activity

            People

              wc-triage WC Triage
              sguminsx Steve Guminski (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: