Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-10467

use standard linux wait_event macros

Details

    • Improvement
    • Resolution: Fixed
    • Major
    • Lustre 2.14.0
    • None
    • None
    • 9223372036854775807

    Description

      Simplify l_wait_info() using the linux wait_event infrastructure.

      Improvements are:

         - new wait_event_idle* macros are now in include/linux/wait.h which

           Ack from peterz.

         - all waits are now TASK_IDLE or TASK_INTERRUPTIBLE and so don't

           affect the load average.  There is no need to choose whether load

           is appropriate or not in each case.

         - all l_wait_event() users are handled so l_wait_event() is

           removed.  The one case I had left out before uses

           wait_event_idle_exclusive() with and option of using

           wait_event_idle_exclusive_lifo() is that ever gets approved.

      Attachments

        Issue Links

          Activity

            [LU-10467] use standard linux wait_event macros

            Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/38405/
            Subject: LU-10467 ptlrpc: change LONG_UNLINK to PTLRPC_REQ_LONG_UNLINK
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 7c549da4014a7c7f7f662876115db16f4b05d74c

            gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/38405/ Subject: LU-10467 ptlrpc: change LONG_UNLINK to PTLRPC_REQ_LONG_UNLINK Project: fs/lustre-release Branch: master Current Patch Set: Commit: 7c549da4014a7c7f7f662876115db16f4b05d74c

            Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/38403/
            Subject: LU-10467 llite: clean up pcc_layout_wait()
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: c5a311781fc60c9a91483b737d3f59096949439e

            gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/38403/ Subject: LU-10467 llite: clean up pcc_layout_wait() Project: fs/lustre-release Branch: master Current Patch Set: Commit: c5a311781fc60c9a91483b737d3f59096949439e

            Neil Brown (neilb@suse.de) uploaded a new patch: https://review.whamcloud.com/38405
            Subject: LU-10467 ptlrpc: change LONG_UNLINK to PTLRPC_LONG_REQ_UNLINK
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 397675ad40fbfdea1dbd7e4667e38b3358501a24

            gerrit Gerrit Updater added a comment - Neil Brown (neilb@suse.de) uploaded a new patch: https://review.whamcloud.com/38405 Subject: LU-10467 ptlrpc: change LONG_UNLINK to PTLRPC_LONG_REQ_UNLINK Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 397675ad40fbfdea1dbd7e4667e38b3358501a24

            Neil Brown (neilb@suse.de) uploaded a new patch: https://review.whamcloud.com/38403
            Subject: LU-10467 llite: clean up pcc_layout_wait()
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 24412377207fa449847bf193707fc74c2de9e42c

            gerrit Gerrit Updater added a comment - Neil Brown (neilb@suse.de) uploaded a new patch: https://review.whamcloud.com/38403 Subject: LU-10467 llite: clean up pcc_layout_wait() Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 24412377207fa449847bf193707fc74c2de9e42c
            pjones Peter Jones added a comment -

            Amazing! Congrats

            pjones Peter Jones added a comment - Amazing! Congrats

            This work is now complete!!!!

            simmonsja James A Simmons added a comment - This work is now complete!!!!

            Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/37729/
            Subject: LU-10467 libcfs: remove l_wait_event() and related macros.
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 39287411e32aeeed342c7da8417975e97310cd4a

            gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/37729/ Subject: LU-10467 libcfs: remove l_wait_event() and related macros. Project: fs/lustre-release Branch: master Current Patch Set: Commit: 39287411e32aeeed342c7da8417975e97310cd4a

            Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/37696/
            Subject: LU-10467 ptlrpc: convert waiting in ptlrpc_hr_main()
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 5891fbfad266623631e89d9f349722343592220d

            gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/37696/ Subject: LU-10467 ptlrpc: convert waiting in ptlrpc_hr_main() Project: fs/lustre-release Branch: master Current Patch Set: Commit: 5891fbfad266623631e89d9f349722343592220d

            Neil Brown (neilb@suse.de) uploaded a new patch: https://review.whamcloud.com/37729
            Subject: LU-10467 libcfs: remove l_wait_event() and related macros.
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 017a47e4eaf756ec54a431ee17aadf37cdc7b888

            gerrit Gerrit Updater added a comment - Neil Brown (neilb@suse.de) uploaded a new patch: https://review.whamcloud.com/37729 Subject: LU-10467 libcfs: remove l_wait_event() and related macros. Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 017a47e4eaf756ec54a431ee17aadf37cdc7b888

            Down to two patches - 

            https://review.whamcloud.com/#/c/37696/

            https://review.whamcloud.com/#/c/37473/

            Plus we will need one cleanup patch.

            simmonsja James A Simmons added a comment - Down to two patches -  https://review.whamcloud.com/#/c/37696/ https://review.whamcloud.com/#/c/37473/ Plus we will need one cleanup patch.

            People

              simmonsja James A Simmons
              simmonsja James A Simmons
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: