[LU-8945] Stop building ptlrpc/layout.c in userland

• Type: Improvement
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.10.0
• Affects Version/s: Lustre 2.10.0
• Assignee: James A Simmons
• Reporter: James A Simmons

Description

Currently a user land utility req-layout does evil things like include layout.c from the ptlrpc layout into its user land source file. This ends up pull lots of unnecessary kernel code into user land as well as libcfs kernel headers. If we really need the req-layout tool this it would be better to export the data via debugfs. The question also is this utility really needed anymore. The other option is to delete req-layout.c

Issue Links

• is related to: LU-6401 Untangle lustre userland and kernel headers

Comments

[Peter Jones]

Landed for 2.10

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/24396/
Subject: LU-8945 ptlrpc : remove userland usage from ptlrpc
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: fb403f8b5f8ba61fe0da28e7f7c5e01776717750

[James A Simmons]

This cleanup is one of the last blockers of completely removing the libcfs headers from userland.

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/24396
Subject: LU-8945 ptlrpc : remove userland usage from ptlrpc
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: f2eb7f40c489344e43c4a15b93f53cc89b239953

[James A Simmons]

True, wireshark is a much better solution. Here is a sample of the output, otherwise it is too long.

L OBD_PING (1/1)
FC 0 [000] ptlrpc_body (184)
-----------------------------------
FS 0 [000] ptlrpc_body (184)

L OBD_SET_INFO (3/1)
FC 0 [000] ptlrpc_body (184)
FC 1 [184] setinfo_key (var)
FC 2 [184 + ...] setinfo_val (var)
-----------------------------------
FS 0 [000] ptlrpc_body (184)

L OBD_IDX_READ (2/2)
FC 0 [000] ptlrpc_body (184)
FC 1 [184] idx_info (080)
-----------------------------------
FS 0 [000] ptlrpc_body (184)
FS 1 [184] idx_info (080)

L SEC_CTX (1/1)
FC 0 [000] ptlrpc_body (184)
-----------------------------------
FS 0 [000] ptlrpc_body (184)

L MGS_TARGET_REG (2/2)
FC 0 [000] ptlrpc_body (184)
FC 1 [184] mgs_target_info (4544)
-----------------------------------
FS 0 [000] ptlrpc_body (184)
FS 1 [184] mgs_target_info (4544)

[Andreas Dilger]

PS: it wouldn't be terrible to run it once and post the output in a comment here for posterity, since this might be useful for anyone looking at RPC structures.

[Andreas Dilger]

While req_layout appears to be somewhat interesting (I didn't know this existed) I don't think anyone is actually using it. We would be far better off to do this kind of structure decoding in wireshark, and this utility can almost certainly be removed.