[LU-9091] Replace lprocfs_str_with_units_to_s64 with string_get_size()

• Type: Improvement
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.14.0
• Labels: patch
• Assignee: James A Simmons
• Reporter: James A Simmons

Description

The latest kernels have introduced a function that is very similar to what was done in LU-7334. The difference is the unit labels i.e M instead of MB. Upstream will be wanting us to use this standard function.

Issue Links

• is related to: LU-10517 setting llite.*.checksum_pages doesn't actually work
• is related to: LU-11157 sanity test_42e: invalid arithmetic operator (error token is ".9")
• is related to: LU-12511 Prepare lustre for adoption into the linux kernel
• is related to: LU-8066 Move lustre procfs handling to sysfs and debugfs.
• is related to: LU-7334 Refactor lprocfs helpers

Comments

[James A Simmons]

Yep its finished!!!

[Peter Jones]

Finally?

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/37275/
Subject: LU-9091 procfs: remove old string parsing routines
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 48242f98c3add59d9e084d73057e64265230a19f

[James A Simmons]

One last cleanup patch to land - https://review.whamcloud.com/#/c/37275/

[Peter Jones]

Seems to have all landed for 2.14

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/37620/
Subject: LU-9091 obdclass: allow bare KMGTPE param suffix
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: d105cc4a6448b3c842790d0e1f0380b94d087f6f

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/37622
Subject: LU-9091 sysfs: add memparse format support for defunit
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 63b1825928c5f7d6ed8bc906d5983c71a9d74c54

[James A Simmons]

https://review.whamcloud.com/#/c/34849

https://review.whamcloud.com/#/c/37275

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/37274
Subject: LU-9091 obd: move remaining sysfs that needs units to sysfs_memparse()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 5a13c7eccc3df9f34d2088cdaa0a9439b4286c05

[James A Simmons]

Another patch is needed as well as a final cleanup patch.