Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-9127

too many debug messages from tgt_cb_last_committed()

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.10.0
    • Lustre 2.7.0
    • 3
    • 9223372036854775807

    Description

      tgt_cb_last_committed() prints a D_HA message even if last_committed was not updated.

      The problem is the cpu overhead associated with a bunch of similar (and mostly useless) messages and potential Lustre debug log overflow.

      A trivial patch will be uploaded shortly.

      Attachments

        Activity

          [LU-9127] too many debug messages from tgt_cb_last_committed()
          pjones Peter Jones added a comment -

          Landed for 2.10

          pjones Peter Jones added a comment - Landed for 2.10
          gerrit Gerrit Updater added a comment -

          Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/25469/
          Subject: LU-9127 target: tgt_cb_last_committed is too noisy
          Project: fs/lustre-release
          Branch: master
          Current Patch Set:
          Commit: 11eda8742fa4505bc62c6113b067a75687f171cc

          gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/25469/ Subject: LU-9127 target: tgt_cb_last_committed is too noisy Project: fs/lustre-release Branch: master Current Patch Set: Commit: 11eda8742fa4505bc62c6113b067a75687f171cc
          adilger Andreas Dilger added a comment -

          Ah, I see it now...

          adilger Andreas Dilger added a comment - Ah, I see it now...
          adilger Andreas Dilger added a comment -

          Is this different from patch http://review.whamcloud.com/14611:

             LU-6527 ext4: journal_commit_callback optimization
    
    Don't take spinlock in tgt_cb_last_committed, if
    exp_last_committed was updated with higher trasno.
    Also change list_add_tail to list_add. It gives
    advantages to ldiskfs in tgt_cb_last_committed.
    In the beginning of list will be placed thandles
    with the highest transaction numbers. So at the
    first iterations we will have the highest transno.
    It will save from extra call of ptlrpc_commit_replies.

    Signed-off-by: Sergey Cheremencev <sergey.cheremencev@seagate.com>
    Xyratex-bug-id: MRP-2575

          That was landed to master for 2.7.61 but and the backport for b2_7_fe is https://review.whamcloud.com/19904

          adilger Andreas Dilger added a comment - Is this different from patch http://review.whamcloud.com/14611: LU-6527 ext4: journal_commit_callback optimization Don't take spinlock in tgt_cb_last_committed, if exp_last_committed was updated with higher trasno. Also change list_add_tail to list_add. It gives advantages to ldiskfs in tgt_cb_last_committed. In the beginning of list will be placed thandles with the highest transaction numbers. So at the first iterations we will have the highest transno. It will save from extra call of ptlrpc_commit_replies. Signed-off-by: Sergey Cheremencev <sergey.cheremencev@seagate.com> Xyratex-bug-id: MRP-2575 That was landed to master for 2.7.61 but and the backport for b2_7_fe is https://review.whamcloud.com/19904
          gerrit Gerrit Updater added a comment -

          Andrew Perepechko (andrew.perepechko@seagate.com) uploaded a new patch: https://review.whamcloud.com/25469
          Subject: LU-9127 target: tgt_cb_last_committed is too noisy
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 5432848f7eb666babf4193320499540f48bc23a0

          gerrit Gerrit Updater added a comment - Andrew Perepechko (andrew.perepechko@seagate.com) uploaded a new patch: https://review.whamcloud.com/25469 Subject: LU-9127 target: tgt_cb_last_committed is too noisy Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 5432848f7eb666babf4193320499540f48bc23a0

          People

            wc-triage WC Triage
            panda Andrew Perepechko
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: