[LU-9166] missing trailing newlines in mdt/*/hsm/policy and mdd/*/changelog_mask

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.10.0
• Labels: easy
• Severity: 3
• Assignee: Steve Guminski (Inactive)
• Reporter: John Hammond

Description

x:~# cat /proc/fs/lustre/mdt/lustre-MDT0000/hsm/policy
NonBlockingRestore [NoRetryAction]x:~# 
x:~# cat /proc/fs/lustre/mdd/lustre-MDT0000/changelog_mask
MARK CREAT MKDIR HLINK SLINK MKNOD UNLNK RMDIR RENME RNMTO OPEN CLOSE LYOUT TRUNC SATTR XATTR HSM MTIME CTIME MIGRT x:~# 

We should also add a test to sanity to check that all readable non-empty proc files have a trailing newline (except possibly for a short list of known exceptions). A missing trailing newline doesn't look nice has has been known to confuse test scripts.

Issue Links

• is related to: LU-7092 Interop 2.7.0<->master sanity test_133g 133f failed: mds1 find /proc/fs/lustre/ /proc/sys/lnet/ /proc/sys/lustre/ /sys/fs/lustre/ /sys/kernel/debug/lustre/ failed

Comments

[Peter Jones]

Landed for 2.10

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/25977/
Subject: LU-9166 mdt: Add trailing newlines to proc files
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 89c31f6814a49a2697259ffe57e480e6653d31ee

[Gerrit Updater]

Steve Guminski ([e-mail]) uploaded a new patch: https://review.whamcloud.com/25977
Subject: LU-9166 mdt: Add trailing newlines to proc files
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d7e17bfa78c641df310b7ac1a8ec90667e9c03e5

[Steve Guminski (Inactive)]

Sure.

[Joseph Gmitter (Inactive)]

Hi Steve,

Could you add this to your queue as well?

Thanks.
Joe