[LU-9243] GSS struct definition badness

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.16.0, Lustre 2.15.2
• Affects Version/s: Lustre 2.15.0
• Severity: 3
• Assignee: Sebastien Buisson
• Reporter: John Hammond

Description

struct lgssd_ioctl_param is defined is two places, which is bad:

C symbol: lgssd_ioctl_param

  File                               Function            Line
0 lustre/ptlrpc/gss/gss_cli_upcall.c <global>            214 struct lgssd_ioctl_param {
1 lustre/utils/gss/lsupport.h        <global>             98 struct lgssd_ioctl_param {
2 lustre/ptlrpc/gss/gss_cli_upcall.c gss_do_ctx_init_rpc 233 struct lgssd_ioctl_param param;
3 lustre/utils/gss/gssd_proc.c       do_negotiation      442 struct lgssd_ioctl_param param;
4 lustre/utils/gss/lgss_keyring.c    do_nego_rpc         127 struct lgssd_ioctl_param param;

struct gss_header and others are going on the wire but are only defined in lustre/ptlrpc/gss/gss_internal.h and are not wirechecked.