Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-9318

sanity-lsnapshot should be skipped for all non-ZFS configs

Details

    • Bug
    • Resolution: Fixed
    • Major
    • Lustre 2.10.0
    • Lustre 2.10.0
    • Interop:
      server: RHEL7.3, 2.9 Lustre, ldiskfs
      client: RHEL7.3, 2.10 Lustre
    • 3
    • 9223372036854775807

    Attachments

      Issue Links

        is related to

        Bug - A problem which impairs or prevents the functions of the product. LU-9320 sanity test_801a: Fail to prep barrier test env

        • Minor - Minor loss of function, or other problem where easy workaround is present.
        • Resolved
        mentioned in

        [Whamcloud Community Wiki] Page Page No Confluence page found with the given URL.

        Activity

          [LU-9318] sanity-lsnapshot should be skipped for all non-ZFS configs
          pjones Peter Jones added a comment -

          Landed for 2.10

          pjones Peter Jones added a comment - Landed for 2.10
          gerrit Gerrit Updater added a comment -

          Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/26600/
          Subject: LU-9318 test: sanity-lsnapshot skipped for all non-zfs configs
          Project: fs/lustre-release
          Branch: master
          Current Patch Set:
          Commit: eb3379162c9c3044759013390cdba7b53783b31d

          gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/26600/ Subject: LU-9318 test: sanity-lsnapshot skipped for all non-zfs configs Project: fs/lustre-release Branch: master Current Patch Set: Commit: eb3379162c9c3044759013390cdba7b53783b31d
          gerrit Gerrit Updater added a comment -

          Saurabh Tandan (saurabh.tandan@intel.com) uploaded a new patch: https://review.whamcloud.com/26600
          Subject: LU-9318 test: sanity-lsnapshot skipped for all non-zfs configs
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 57433a0b141b5791d0347d9e6c22d21dd1d82c6d

          gerrit Gerrit Updater added a comment - Saurabh Tandan (saurabh.tandan@intel.com) uploaded a new patch: https://review.whamcloud.com/26600 Subject: LU-9318 test: sanity-lsnapshot skipped for all non-zfs configs Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 57433a0b141b5791d0347d9e6c22d21dd1d82c6d
          adilger Andreas Dilger added a comment - - edited

          This just needs a check at the start of the script to skip the whole thing if not running with ZFS, or if the version is too old:

          [ $(lustre_version_code mds1) -lt $(version_code 2.9.55) ||
  $(lustre_version_code ost1) -lt $(version_code 2.9.55) ] &&
        skip "Need server version at least 2.9.55" && exit 0
[ $(facet_fstype mds1) = "ldiskfs" ] || $(facet_fstype ost1) = "ldiskfs" ] &&
        skip "can't test snapshots with ldiskfs" && exit 0
          adilger Andreas Dilger added a comment - - edited This just needs a check at the start of the script to skip the whole thing if not running with ZFS, or if the version is too old: [ $(lustre_version_code mds1) -lt $(version_code 2.9.55) || $(lustre_version_code ost1) -lt $(version_code 2.9.55) ] && skip "Need server version at least 2.9.55" && exit 0 [ $(facet_fstype mds1) = "ldiskfs" ] || $(facet_fstype ost1) = "ldiskfs" ] && skip "can't test snapshots with ldiskfs" && exit 0
          jamesanunez James Nunez (Inactive) added a comment -

          The problem here is that the check for a ZFS file system is after the script tries to add snapshot to the debug list.

           
00:27:14:CMD: onyx-47vm7 /usr/sbin/lctl set_param debug=+snapshot
00:27:14:onyx-47vm7: error: set_param: setting /proc/sys/lnet/debug=+snapshot: Invalid argument
00:27:14:sanity-lsnapshot returned 0

          This is a script issue and I'll convert ticket to LU.

          jamesanunez James Nunez (Inactive) added a comment - The problem here is that the check for a ZFS file system is after the script tries to add snapshot to the debug list. 00:27:14:CMD: onyx-47vm7 /usr/sbin/lctl set_param debug=+snapshot 00:27:14:onyx-47vm7: error: set_param: setting /proc/sys/lnet/debug=+snapshot: Invalid argument 00:27:14:sanity-lsnapshot returned 0 This is a script issue and I'll convert ticket to LU.
          jcasper James Casper (Inactive) added a comment -

          sanity-lsnapshot should only be run on zfs configs.

          Of our 7 regression and interop configs, only 2 use ZFS. It was correctly skipped or
          absent for 4 of the 5 ldiskfs configs.

          jcasper James Casper (Inactive) added a comment - sanity-lsnapshot should only be run on zfs configs. Of our 7 regression and interop configs, only 2 use ZFS. It was correctly skipped or absent for 4 of the 5 ldiskfs configs.
          mdiep Minh Diep added a comment -

          James, could you tell us the reason for skipping? and shouldn't this be in lustre tree, not auto test?

          mdiep Minh Diep added a comment - James, could you tell us the reason for skipping? and shouldn't this be in lustre tree, not auto test?

          People

            standan Saurabh Tandan (Inactive)
            jcasper James Casper (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: