Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-9325

Improve lustre kernel string handling

Details

    • Improvement
    • Resolution: Fixed
    • Minor
    • Lustre 2.16.0
    • Lustre 2.10.0
    • 9223372036854775807

    Description

      While pushing work upstream some of the feedback was related to how Lustre does its own direct parsing of string which is frowned on. Secondly we are still not using newer kernel string interfaces like kstrtoul instead of simple_string() and other examples exist as well that have been merged upstream.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-18066 client mount options can be lost

          • Major - Major loss of function.
          • Resolved

          Task - A task that needs to be done. LU-12861 Add and use scnprintf() where using snprintf() is not handling return correctly

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. LU-12511 Prepare lustre for adoption into the linux kernel

          • Major - Major loss of function.
          • Open
          is related to

          Technical task - A technical task. LU-4423 Tracking of patches from upstream kernel to Lustre client

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            [LU-9325] Improve lustre kernel string handling
            simmonsja James A Simmons made changes -
            Link New: This issue is related to LU-18066 [ LU-18066 ]
            pjones Peter Jones added a comment -

            (standing ovation)

            pjones Peter Jones added a comment - (standing ovation)
            simmonsja James A Simmons made changes -
            Fix Version/s New: Lustre 2.16.0 [ 15190 ]
            Fix Version/s Original: Upstream [ 12991 ]
            Resolution New: Fixed [ 1 ]
            Status Original: In Progress [ 3 ] New: Resolved [ 5 ]
            simmonsja James A Simmons added a comment -

            After all these years this work is complete.

            simmonsja James A Simmons added a comment - After all these years this work is complete.
            gerrit Gerrit Updater added a comment -

            "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/51209/
            Subject: LU-9325 obdclass: use match_table for server mount options
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 415fa27540dd444d7d5e42cb8e0c7a3379374b2a

            gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/51209/ Subject: LU-9325 obdclass: use match_table for server mount options Project: fs/lustre-release Branch: master Current Patch Set: Commit: 415fa27540dd444d7d5e42cb8e0c7a3379374b2a
            simmonsja James A Simmons made changes -
            Status Original: Open [ 1 ] New: In Progress [ 3 ]
            gerrit Gerrit Updater added a comment -

            "James Simmons <jsimmons@infradead.org>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/51209
            Subject: LU-9325 obdclass: use match_table for server mount options
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 234816c141dcb499b50963f33ac6c05b9d5f79e8

            gerrit Gerrit Updater added a comment - "James Simmons <jsimmons@infradead.org>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/51209 Subject: LU-9325 obdclass: use match_table for server mount options Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 234816c141dcb499b50963f33ac6c05b9d5f79e8
            simmonsja James A Simmons added a comment -

            Down to two patches.

            simmonsja James A Simmons added a comment - Down to two patches.
            gerrit Gerrit Updater added a comment -

            "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49910/
            Subject: LU-9325 obd: replace simple_strtoul()
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 79b34a83f811f5f1dc40a077bd6d5f65194c9bbe

            gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49910/ Subject: LU-9325 obd: replace simple_strtoul() Project: fs/lustre-release Branch: master Current Patch Set: Commit: 79b34a83f811f5f1dc40a077bd6d5f65194c9bbe
            gerrit Gerrit Updater added a comment -

            "jsimmons <jsimmons@infradead.org>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49910
            Subject: LU-9325 obd: replace simple_strtoul()
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 6da5463b9e39c149c3c6717398dc93eb3cc57d0d

            gerrit Gerrit Updater added a comment - "jsimmons <jsimmons@infradead.org>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49910 Subject: LU-9325 obd: replace simple_strtoul() Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 6da5463b9e39c149c3c6717398dc93eb3cc57d0d

            People

              simmonsja James A Simmons
              simmonsja James A Simmons
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: