[LU-9325] Improve lustre kernel string handling

• Type: Improvement
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.16.0
• Affects Version/s: Lustre 2.10.0
• Labels: patch

Epic/Theme

upstream

• Assignee: James A Simmons
• Reporter: James A Simmons

Description

While pushing work upstream some of the feedback was related to how Lustre does its own direct parsing of string which is frowned on. Secondly we are still not using newer kernel string interfaces like kstrtoul instead of simple_string() and other examples exist as well that have been merged upstream.

Issue Links

• is related to: LU-18066 client mount options can be lost
• is related to: LU-12861 Add and use scnprintf() where using snprintf() is not handling return correctly
• is related to: LU-12511 Prepare lustre for adoption into the linux kernel
• is related to: LU-4423 Tracking of patches from upstream kernel to Lustre client

Comments

[Peter Jones]

(standing ovation)

[James A Simmons]

After all these years this work is complete.

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/51209/
Subject: LU-9325 obdclass: use match_table for server mount options
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 415fa27540dd444d7d5e42cb8e0c7a3379374b2a

[Gerrit Updater]

"James Simmons <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/51209
Subject: LU-9325 obdclass: use match_table for server mount options
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 234816c141dcb499b50963f33ac6c05b9d5f79e8

[James A Simmons]

Down to two patches.

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49910/
Subject: LU-9325 obd: replace simple_strtoul()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 79b34a83f811f5f1dc40a077bd6d5f65194c9bbe

[Gerrit Updater]

"jsimmons <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49910
Subject: LU-9325 obd: replace simple_strtoul()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 6da5463b9e39c149c3c6717398dc93eb3cc57d0d

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/33617/
Subject: LU-9325 obdclass: make niduuid for lustre_stop_mgc() static
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 85b400b67b0d8d49315f80252025c98303d242bb

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/40119/
Subject: LU-9325 osd-ldisk: replace simple_strto* with kstr* functions
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: e520b6a7fa6b6dd3f703dc8c6918a3699b3d9517

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/40119
Subject: LU-9325 osd-ldisk: replace simple_strto* with kstr* functions
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 8ddd1d616f35a9b9937631fa5e6d653d8e855886