[LU-946] add lprocfs file on MDT to list open files in the filesystem

• Type: Improvement
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.6.0, Lustre 2.5.1
• Labels: patch
• Story Points: 5
• Assignee: Emoly Liu
• Reporter: Andreas Dilger

Description

Several customers have asked for the ability to list open files on the whole filesystem. Currently this is only possible to do on the clients by running "lsof" but is impractical to do.

This would likely be implemented by walking all of the client exports and then listing all of the objects in med_open_head as NID_FID pairs. Userspace could then sort/print the open files as desired using "lfs fid2path".

Issue Links

• is related to: LU-4429 clients leaking open handles/bad lock matching in ll_md_blocking_ast
• is related to: LU-3223 allow "lfs fid2path" to handle multiple FIDs on the command-line

Comments

[Emoly Liu]

Patch landed for 2.6

[Girish Shilamkar (Inactive)]

http://review.whamcloud.com/6386

[Andreas Dilger]

Girish,
there is no requirement for the proc file handling to be in obdclass. That is just for common routines shared among multiple modules. Typically each module has its own "mdt_lproc.c" or similar, which has data specific to the module. In this case, the open_file setup should go into the per-export directory /proc/fs/lustre/mdt/*/exports/open_files, created under the mdt_export_stats_init() function.

[Girish Shilamkar (Inactive)]

Andreas,

med_open_head is list of mdt_file_data objects. And struct mdt_file_data is an internal structure to mdt. So we cannot walk med_open_head from obdclass(lprocfs_status.c) using this linked list. We could have had a function in mdt to return lu_object for a given mdt_file_data object but that would make odbclass module dependent on mdt. (mdt is already used by obdclass)
So the only option I see is to export list of open lu_objects/md_objects, structs which are known by obdclass. Please advise.

Other than this layering issue the patch is ready with a testcase.
Thanks,
Girish

[Emoly Liu]

Girish, it says the user doesn't exist. Anyway, you can push your patch to gerrit and paste the link here.

If you don't mind, I'd like to assign to me and take care of the patch.

[Girish Shilamkar (Inactive)]

Hello,

I have started working on this ticket but don't have permissions to assign it to myself.

Regards,
Girish

[Andreas Dilger]

This would ideally be available on the MDS per-export in /proc/fs/lustre/mdt/$fsname-MDTnnnn/exports/$NID/open_files with just a FID list. Userspace could just do lctl get_param mdt.$fsname-MDTnnnn.exports.$NID.open_files and pipe that to lfs fid2path (with my patch in http://review.whamcloud.com/6160 in LU-3223 to handle multiple FIDs on the command-line).