[LU-9474] tests: register traps in a correct order

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.12.0, Lustre 2.10.7
• Labels: patch
• Severity: 3
• Assignee: Saurabh Tandan (Inactive)
• Reporter: CEA

Description

trap is used in many tests to set actions to perform on cleanup.

IMHO, trap should be registered in this order:

cleanup_test_XX()
{
    undo_something
}

test_XX()
{
    trap cleanup_test_XX EXIT
    do_something
    ...
}

Currently many tests do not respect this template.
Among those, some:

• register the trap after do_something();
• explicitly call cleanup_test_XX() at the end of the test;
• call trap 0 at the start of cleanup_test_XX() (this one may be controversial, I believe the test harness should provide, and probably already provides, trap isolation between tests).

Issue Links

• is related to: LU-10461 sanity 77c failure due to variables called in cleanup routine are out of scope
• is related to: LU-9475 tests: provide utilities to stack traps

Comments

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/34158/
Subject: LU-9474 tests: fix quoting in stack_trap
Project: fs/lustre-release
Branch: b2_10
Current Patch Set:
Commit: 4c33ed79380017abfb9a1e34b99bc957257f4d55

[Gerrit Updater]

Jian Yu ([e-mail]) uploaded a new patch: https://review.whamcloud.com/34158
Subject: LU-9474 tests: fix quoting in stack_trap
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: d7f6102a1ee47ba01f202c66a80d5a3f213501f5

[Peter Jones]

Looks like this work has all landed now

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/30098/
Subject: LU-9474 tests: replace import_file with copytool import
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 61089d59a672e0e3760e52cc1e6fc7f10caaf00e

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/31429/
Subject: LU-9474 tests: remove unneeded hsm_set_param for raolu tests
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 804739be1f3bdd28e47d2e71b8ca78923549db25

[Gerrit Updater]

Quentin Bouget ([e-mail]) uploaded a new patch: https://review.whamcloud.com/31429
Subject: LU-9474 tests: remove unneeded hsm_set_param for raolu tests
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 93e92575b03e1982e52734369b9cde3cb92dd786

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/30490/
Subject: LU-9474 tests: fix quoting in stack_trap
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 99420a1830b89a8aba6350b095065d65107f7c0f

[Gerrit Updater]

John L. Hammond ([e-mail]) merged in patch https://review.whamcloud.com/30371/
Subject: LU-9474 tests: add the stack_trap() utility function
Project: fs/lustre-release
Branch: b2_10
Current Patch Set:
Commit: eb9c7a25c8d62e549d1c41df0bf047bc2b1d63b4

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/30097/
Subject: LU-9474 tests: rewrite copytool_setup to use stack_trap
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 2042bcea662847c12cacdecd598b0a0d5fa4d805

[Gerrit Updater]

Quentin Bouget ([e-mail]) uploaded a new patch: https://review.whamcloud.com/30490
Subject: LU-9474 tests: fix quoting in stack_trap
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 8e086c102cbaabf3cf2be6645a2891064f057e13