[LU-9490] MPI-IO Lustre ADIO driver gets Lustre layout parameters incorrectly

• Type: Bug
• Resolution: Fixed
• Priority: Critical
• Fix Version/s: Lustre 2.10.0
• Affects Version/s: Lustre 2.10.0
• Severity: 3
• Assignee: Emoly Liu
• Reporter: Andreas Dilger

Description

Looking at the Lustre ADIO driver, it appears that it is retrieving the layout parameters (stripe count, stripe size) incorrectly from the kernel. It is calling an ioctl() directly to the kernel, but then not checking that the returned layout magic is something that it understands before dereferencing the fields of struct lov_mds_md. For composite files that for not have struct lov_mds_md directly at the start of the layout, this will deteference random fields in the layout and return garbage to the library.

Issue Links

• is related to: LU-10232 kernel BUG at cl_object.c:206!
• is related to: LU-7964 tracking whether there is a direct application usage of regular file LL_IOC_LOV_GETSTRIPE ioctl interface
• is related to: LU-9550 Delete the old Lustre ADIO driver patches
• is related to: LU-9349 PFL known issues tracking ticket

Comments

[Eric Bergland (Inactive)]

ADIO changes being tracked in LU-9657

[Peter Jones]

Lustre changes all landed for 2.10. ADIO changes being tracked separately

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/27180/
Subject: LU-9490 tests: ll_dirstripe_verify handles PFL layout
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: c1359f54314084e0613a5ae70168595f296b7dfc

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/27183/
Subject: LU-9490 llite: return v1/v3 layout for legacy app
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 545f464b68ee21ccc425113db9b57c63ac2840b1

[Gerrit Updater]

Andreas Dilger ([e-mail]) merged in patch https://review.whamcloud.com/27310/
Subject: LU-9490 llite: return v1/v3 layout for legacy app
Project: fs/lustre-release
Branch: pfl
Current Patch Set:
Commit: fac27756d5f2a283a5ec7a908e6434d30748a6bd

[Gerrit Updater]

Andreas Dilger ([e-mail]) uploaded a new patch: https://review.whamcloud.com/27310
Subject: LU-9490 llite: return v1/v3 layout for legacy app
Project: fs/lustre-release
Branch: pfl
Current Patch Set: 1
Commit: f3e00e27e8f86be9400df19f074b23da6d2b17fb

[Emoly Liu]

Discussed with Niu and worked on how to apply each component stripe information to the I/O pattern redistribution.

[Andreas Dilger]

Emoly, yes the fix should be submitted to the MPICH Git repo. The ADIO patches in lustre/contrib should be deleted.

[Emoly Liu]

adilger, I'm cloning MPICH git repo. Do you mean I need to create a patch there?
BTW, the lustre ADIO driver patch in our repo (lustre/contrib/adio_driver_mpich2-1.0.7.patch) is too old, I remembered it was released by MPICH2 about 8 years ago. Should it be removed?

[Emoly Liu]

I will look into this one.