[LU-9863] Potential one off bug in lmv_fid2path

• Type: Bug
• Resolution: Fixed
• Priority: Major
• Fix Version/s: Lustre 2.11.0
• Affects Version/s: Upstream, Lustre 2.11.0
• Labels: patch
• Severity: 3
• Assignee: James A Simmons
• Reporter: James A Simmons

Description

Potential off by two in lmv_fid2path()

We want to concatonate join string one, a '/' character, string two and
then a NUL terminator. The destination buffer holds ori_gf->gf_pathlen
characters. The strlen() function returns the number of characters not
counting the NUL terminator. So we should be adding two extra spaces,
one for the foward slash and one for the NULL..

Issue Links

• is related to: LU-9679 Prepare lustre for adoption into the linux kernel

Comments

[Peter Jones]

Does this affect 2.10.x?

[Peter Jones]

Landed for 2.11

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/28477/
Subject: LU-9863 lmv: Off by two in lmv_fid2path()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 3f86915bdfe506ac9070f091b5a1c52ed134f5d2

[James A Simmons]

So someone has actually been impacted by this bug.

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/28477
Subject: LU-9863 lmv: Off by two in lmv_fid2path()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 6d81128c753d610fd01412e153b7e9af667b3583