Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-9997

Suspicious assert check in ldlm_cli_cancel

Details

    • 3
    • 9223372036854775807

    Description

      The assert in ldlm_cli_cancel() seems to be problematic:

              /* Even if the lock is marked as LDLM_FL_BL_AST, this is a LDLM_CANCEL  
               * RPC which goes to canceld portal, so we can cancel other LRU locks   
               * here and send them all as one LDLM_CANCEL RPC. */                    
              LASSERT(list_empty(&lock->l_bl_ast));                                   
              list_add(&lock->l_bl_ast, &cancels);  
      

      because the lock may have been picked up LRU and added into canceling list.

      Attachments

        Issue Links

          Activity

            [LU-9997] Suspicious assert check in ldlm_cli_cancel

            John L. Hammond (john.hammond@intel.com) merged in patch https://review.whamcloud.com/30339/
            Subject: LU-9997 ldlm: check lock cancellation in ldlm_cli_cancel()
            Project: fs/lustre-release
            Branch: b2_10
            Current Patch Set:
            Commit: 5de61ac6736ed1bfd7425bab4b2c5f7319f65d8e

            gerrit Gerrit Updater added a comment - John L. Hammond (john.hammond@intel.com) merged in patch https://review.whamcloud.com/30339/ Subject: LU-9997 ldlm: check lock cancellation in ldlm_cli_cancel() Project: fs/lustre-release Branch: b2_10 Current Patch Set: Commit: 5de61ac6736ed1bfd7425bab4b2c5f7319f65d8e
            mdiep Minh Diep added a comment -

            Landed in Lustre 2.11.0

            mdiep Minh Diep added a comment - Landed in Lustre 2.11.0

            Minh Diep (minh.diep@intel.com) uploaded a new patch: https://review.whamcloud.com/30339
            Subject: LU-9997 ldlm: check lock cancellation in ldlm_cli_cancel()
            Project: fs/lustre-release
            Branch: b2_10
            Current Patch Set: 1
            Commit: 79ca91495ca315ed2a955e60fad7eaf53fafc0f9

            gerrit Gerrit Updater added a comment - Minh Diep (minh.diep@intel.com) uploaded a new patch: https://review.whamcloud.com/30339 Subject: LU-9997 ldlm: check lock cancellation in ldlm_cli_cancel() Project: fs/lustre-release Branch: b2_10 Current Patch Set: 1 Commit: 79ca91495ca315ed2a955e60fad7eaf53fafc0f9

            Jinshan Xiong (jinshan.xiong@intel.com) merged in patch https://review.whamcloud.com/29080/
            Subject: LU-9997 ldlm: check lock cancellation in ldlm_cli_cancel()
            Project: fs/lustre-release
            Branch: flr
            Current Patch Set:
            Commit: f4ea4017b4d6a420146b2959f9feb11866858b4a

            gerrit Gerrit Updater added a comment - Jinshan Xiong (jinshan.xiong@intel.com) merged in patch https://review.whamcloud.com/29080/ Subject: LU-9997 ldlm: check lock cancellation in ldlm_cli_cancel() Project: fs/lustre-release Branch: flr Current Patch Set: Commit: f4ea4017b4d6a420146b2959f9feb11866858b4a

            Jinshan Xiong (jinshan.xiong@intel.com) uploaded a new patch: https://review.whamcloud.com/29080
            Subject: LU-9997 ldlm: check lock cancellation in ldlm_cli_cancel()
            Project: fs/lustre-release
            Branch: flr
            Current Patch Set: 1
            Commit: c1f350527458584ab7181a5fae06d21ff00371cc

            gerrit Gerrit Updater added a comment - Jinshan Xiong (jinshan.xiong@intel.com) uploaded a new patch: https://review.whamcloud.com/29080 Subject: LU-9997 ldlm: check lock cancellation in ldlm_cli_cancel() Project: fs/lustre-release Branch: flr Current Patch Set: 1 Commit: c1f350527458584ab7181a5fae06d21ff00371cc

            Jinshan Xiong (jinshan.xiong@intel.com) uploaded a new patch: https://review.whamcloud.com/29025
            Subject: LU-9997 ldlm: check lock cancellation in ldlm_cli_cancel()
            Project: fs/lustre-dev
            Branch: flr2
            Current Patch Set: 1
            Commit: 863b971d39f210f8ac351e8928266c2075fae4ff

            gerrit Gerrit Updater added a comment - Jinshan Xiong (jinshan.xiong@intel.com) uploaded a new patch: https://review.whamcloud.com/29025 Subject: LU-9997 ldlm: check lock cancellation in ldlm_cli_cancel() Project: fs/lustre-dev Branch: flr2 Current Patch Set: 1 Commit: 863b971d39f210f8ac351e8928266c2075fae4ff

            Jinshan Xiong (jinshan.xiong@intel.com) uploaded a new patch: https://review.whamcloud.com/29021
            Subject: LU-9997 ldlm: check lock cancellation in ldlm_cli_cancel()
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 5fc2e558da6302ce208c06d106b8e59bdf1d751a

            gerrit Gerrit Updater added a comment - Jinshan Xiong (jinshan.xiong@intel.com) uploaded a new patch: https://review.whamcloud.com/29021 Subject: LU-9997 ldlm: check lock cancellation in ldlm_cli_cancel() Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 5fc2e558da6302ce208c06d106b8e59bdf1d751a

            People

              jay Jinshan Xiong (Inactive)
              jay Jinshan Xiong (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: