[LU-9997] Suspicious assert check in ldlm_cli_cancel

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.11.0, Lustre 2.10.3
• Severity: 3
• Assignee: Jinshan Xiong (Inactive)
• Reporter: Jinshan Xiong (Inactive)

Description

The assert in ldlm_cli_cancel() seems to be problematic:

        /* Even if the lock is marked as LDLM_FL_BL_AST, this is a LDLM_CANCEL  
         * RPC which goes to canceld portal, so we can cancel other LRU locks   
         * here and send them all as one LDLM_CANCEL RPC. */                    
        LASSERT(list_empty(&lock->l_bl_ast));                                   
        list_add(&lock->l_bl_ast, &cancels);  

because the lock may have been picked up LRU and added into canceling list.

Issue Links

• is related to: LU-10293 racer test_1: ASSERTION( list_empty(&lock->l_bl_ast) ) failed

Comments

[Gerrit Updater]

John L. Hammond ([e-mail]) merged in patch https://review.whamcloud.com/30339/
Subject: LU-9997 ldlm: check lock cancellation in ldlm_cli_cancel()
Project: fs/lustre-release
Branch: b2_10
Current Patch Set:
Commit: 5de61ac6736ed1bfd7425bab4b2c5f7319f65d8e

[Minh Diep]

Landed in Lustre 2.11.0

[Gerrit Updater]

Minh Diep ([e-mail]) uploaded a new patch: https://review.whamcloud.com/30339
Subject: LU-9997 ldlm: check lock cancellation in ldlm_cli_cancel()
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: 79ca91495ca315ed2a955e60fad7eaf53fafc0f9