[LU-10454] mdd: NULL pointer dereference in mdd_changelog_data_store_by_fid()

• Type: Bug
• Resolution: Fixed
• Priority: Major
• Fix Version/s: Lustre 2.11.0
• Affects Version/s: Lustre 2.11.0
• Labels: patch
• Severity: 3
• Assignee: Quentin Bouget (Inactive)
• Reporter: CEA

Description

mdd_changelog_data_store_by_fid() uses lu_ucred() but only part of the function is aware that the return value may be NULL.This issue is more or less a duplicate of LU-5938 (at least the fix is similar).

Here is a failed test run that ran into the issue (and more precisely, here is thelog file that highlights the issue).

Issue Links

• is duplicated by: LU-10450 NULL pointer deref in mdd_changelog_data_store_by_fid+0xfa
• is related to: LU-5938 sanity-hsm test_52 MDS OOPS: mdd_changelog_data_store

Comments

[Peter Jones]

Landed for 2.11. Is this needed on b2_10?

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/30707/
Subject: LU-10454 mdd: check return value of lu_ucred()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 45b3c7a05aac591b6b339bece4ff48306b29f00f

[Andreas Dilger]

This is one reason why I've been asking for the llog_reader functionality in https://review.whamcloud.com/30315 to be included into each of the patches adding functionality, and then testing that functionality in the patch that adds it...

[Quentin Bouget (Inactive)]

My bad (that's twice now =/).

[Bruno Faccini (Inactive)]

Hello Quentin, this problem had just been reported by Oleg in LU-10450 !!
BTW, your fix proposal looks ok to address the Oops but as per Oleg's comments there, code from suspected LU-9727 patch at https://review.whamcloud.com/28114 may also need more adjustments.

[Gerrit Updater]

Quentin Bouget ([e-mail]) uploaded a new patch: https://review.whamcloud.com/30707
Subject: LU-10454 mdd: check return value of lu_ucred()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: befe4f4ed9bdc94a76d4bb564a3c11e5f6b8088d