[LU-10467] use standard linux wait_event macros

• Type: Improvement
• Resolution: Fixed
• Priority: Major
• Fix Version/s: Lustre 2.14.0
• Assignee: James A Simmons
• Reporter: James A Simmons

Description

Simplify l_wait_info() using the linux wait_event infrastructure.

Improvements are:

   - new wait_event_idle* macros are now in include/linux/wait.h which

     Ack from peterz.

   - all waits are now TASK_IDLE or TASK_INTERRUPTIBLE and so don't

     affect the load average.  There is no need to choose whether load

     is appropriate or not in each case.

   - all l_wait_event() users are handled so l_wait_event() is

     removed.  The one case I had left out before uses

     wait_event_idle_exclusive() with and option of using

     wait_event_idle_exclusive_lifo() is that ever gets approved.

Issue Links

• is related to: LU-10824 ll_umount being improper use of cached mountpoint from mount time
• is related to: LU-1882 conf-sanity test_45: umount2: Device or resource busy
• is related to: LU-8841 Replace l_wait_info calls that use zeroed info parameters
• is related to: LU-12362 kernel warning 'do not call blocking ops when !TASK_RUNNING ' in ptlrpcd
• is related to: LU-12436 Memory allocation failure error dropped
• is related to: LU-12511 Prepare lustre for adoption into the linux kernel
• is related to: LU-6431 do not call blocking ops when !TASK_RUNNING
• is related to: LU-4423 Tracking of patches from upstream kernel to Lustre client

Comments

[James A Simmons]

This work is now complete!!!!

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/37729/
Subject: LU-10467 libcfs: remove l_wait_event() and related macros.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 39287411e32aeeed342c7da8417975e97310cd4a

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/37696/
Subject: LU-10467 ptlrpc: convert waiting in ptlrpc_hr_main()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 5891fbfad266623631e89d9f349722343592220d

[Gerrit Updater]

Neil Brown ([e-mail]) uploaded a new patch: https://review.whamcloud.com/37729
Subject: LU-10467 libcfs: remove l_wait_event() and related macros.
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 017a47e4eaf756ec54a431ee17aadf37cdc7b888

[James A Simmons]

Down to two patches - 

https://review.whamcloud.com/#/c/37696/

https://review.whamcloud.com/#/c/37473/

Plus we will need one cleanup patch.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/37610/
Subject: LU-10467 lfsck: use wait_event_idle()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 99d501a0cbd0195d3235dbb91b95952bad938cfa

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/37609/
Subject: LU-10467 ldlm: use wait_event_idle() instead of l_wait_event
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 8284e02eb1631321c07767ed2d1db627592f0b4c

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/37488/
Subject: LU-10467 mdc: change ssleep to msleep_interruptible
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 23cdbb827eee6ee298ed2462dccd3abcf1589f37

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/37696
Subject: LU-10467 ptlrpc: convert waiting in ptlrpc_hr_main()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 6c29c646724eb104ac05ecef0776f0fa13849d16

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35979/
Subject: LU-10467 ptlrpc: convert final users of LWI_TIMEOUT_INTERVAL
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: c30da8bfa199205194eefca2c5d2e6843a29a34b

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35975/
Subject: LU-10467 lustre: use l_wait_event_abortable where appropriate.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 79d51f6c1d9f04aac3e7cbbedadf43a72520d424