Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-10737

Checksum calculation takes the error retrun value of cfs_crypto_hash_init as checksum value

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.11.0
    • None
    • 3
    • 9223372036854775807

    Description

      In the checksum calculation functions: tgt_checksum_niobuf and osc_checksum_bulk,
      it is wrongly taken the failed returun value of cfs_crypto_hash_init as the checksum value.

      Attachments

        Activity

          [LU-10737] Checksum calculation takes the error retrun value of cfs_crypto_hash_init as checksum value
          pjones Peter Jones added a comment -

          Landed for 2.11

          pjones Peter Jones added a comment - Landed for 2.11
          gerrit Gerrit Updater added a comment -

          Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/31448/
          Subject: LU-10737 misc: Wrong checksum return value
          Project: fs/lustre-release
          Branch: master
          Current Patch Set:
          Commit: 28b8f3d9296d632a37e36c68c6000dc0c5e96e5a

          gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/31448/ Subject: LU-10737 misc: Wrong checksum return value Project: fs/lustre-release Branch: master Current Patch Set: Commit: 28b8f3d9296d632a37e36c68c6000dc0c5e96e5a
          lixi Li Xi (Inactive) added a comment -

          I found this problem when trying to add checksum of checksum for T10PI. And Yingjin run some fault injection test to make sure the fix patch works well.

          lixi Li Xi (Inactive) added a comment - I found this problem when trying to add checksum of checksum for T10PI. And Yingjin run some fault injection test to make sure the fix patch works well.
          adilger Andreas Dilger added a comment -

          It would be useful to explain a bit about how this problem was found - hit in real life and under what circumstances, hit in testing, or found with code review (manual inspection or static code analysis)?

          adilger Andreas Dilger added a comment - It would be useful to explain a bit about how this problem was found - hit in real life and under what circumstances, hit in testing, or found with code review (manual inspection or static code analysis)?
          gerrit Gerrit Updater added a comment -

          Yingjin Qian (qian@ddn.com) uploaded a new patch: https://review.whamcloud.com/31448
          Subject: LU-10737 misc: Wrong checksum return value
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 77fc5b4d7a9091691b8ad37a3631c981dff9c7b4

          gerrit Gerrit Updater added a comment - Yingjin Qian (qian@ddn.com) uploaded a new patch: https://review.whamcloud.com/31448 Subject: LU-10737 misc: Wrong checksum return value Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 77fc5b4d7a9091691b8ad37a3631c981dff9c7b4

          People

            qian Qian Yingjin (Inactive)
            qian Qian Yingjin (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: