[LU-12383] lfs project inhert difference between ldiskfs and zfs

• Type: Bug
• Resolution: Fixed
• Priority: Critical
• Fix Version/s: Lustre 2.13.0, Lustre 2.12.3
• Affects Version/s: Lustre 2.13.0
• Labels: quota
• Severity: 3
• Assignee: Wang Shilong (Inactive)
• Reporter: Nathaniel Clark

Description

Regular files inherit the Project Inherit flag in ldiskfs, zfs they do not.

Given the following commands:

mkdir proj
lfs project -sp 1000 proj
touch proj/test
lfs project proj

ldiskfs output:

 1000 P proj/test 

ZFS 0.8.0 output:

 1000 - proj/test

 Both correctly set inherit on sub-directories.

 

This difference in behavior causes sanity-quota test_54 to fail for ZFS 0.8.0

https://testing.whamcloud.com/test_sets/afa8f438-81b8-11e9-869c-52540065bddc

Issue Links

• is blocking: LU-12336 Update ZFS Version to 0.8.2

Comments

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35393/
Subject: LU-12383 utils: only check project inherit bit for dir
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: 1299c5d5f92a7086b48b721d35bfce9ded177b94

[Gerrit Updater]

Wang Shilong ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35393
Subject: LU-12383 utils: only check project inherit bit for dir
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: b84e222d7075acc702a239ee4ece3c71e22576a0

[Peter Jones]

We can reopen this one if it seems likely to complete this work during the 2.13 cycle. If that is in doubt then, sure, let's have a new ticket linked to this one

[Li Xi]

Should we create another ticket to track the ldiskfs patch?

[Peter Jones]

Landed for 2.13

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35076/
Subject: LU-12383 utils: only check project inherit bit for dir
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: e4ad5c17c99e7ede5deabffe0bacdd851240eb86

[Andreas Dilger]

I think it makes sense to include ldiskfs-side patches, so that we get fewer "corrupt" inodes on a filesystem, and hopefully they can mostly be aged out of the filesystem after the ldsiskfs patch has been around for some time.

We will also want a patch for e2fsck to detect and repair these errors on non-directory inodes without complaining too much.

[Wang Shilong (Inactive)]

Andreas,

Since there won't be obvious errors with LU-12383 utils: only check project inherit bit for dir
Do you think we'd better include ldiskfs fix parts too?

[Andreas Dilger]

Please also submit an ldiskfs patch for this, I have also reviewed the ext4 patch on the list.

[Wang Shilong (Inactive)]

FYI, I sent two Linux upstream patches to fix ext4 and f2fs:

http://patchwork.ozlabs.org/patch/1110877/
http://patchwork.ozlabs.org/patch/1110878/