Details

    • 9223372036854775807

    Attachments

      Issue Links

        Activity

          [LU-13839] support for RHEL 8.3

          James Nunez (jnunez@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/41344
          Subject: LU-13839 tests: run DNE/ZFS testing with RHEL7.9
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 59e0a3f229d44fdcaf885cefc3dc854a896a537e

          gerrit Gerrit Updater added a comment - James Nunez (jnunez@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/41344 Subject: LU-13839 tests: run DNE/ZFS testing with RHEL7.9 Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 59e0a3f229d44fdcaf885cefc3dc854a896a537e

          Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/40939/
          Subject: LU-13839 ldiskfs: fix detecting ext4_journal_ensure_credits
          Project: fs/lustre-release
          Branch: master
          Current Patch Set:
          Commit: 2cebaa2bc5cd0554ae2b0b625cf9b6da0b1a16c6

          gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/40939/ Subject: LU-13839 ldiskfs: fix detecting ext4_journal_ensure_credits Project: fs/lustre-release Branch: master Current Patch Set: Commit: 2cebaa2bc5cd0554ae2b0b625cf9b6da0b1a16c6

          Mr NeilBrown (neilb@suse.de) uploaded a new patch: https://review.whamcloud.com/40939
          Subject: LU-13839 ldiskfs: fix detecting ext4_journal_ensure_credits
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 3
          Commit: a25b7b26c3e722011686e762b80df64bd1d24749

          adilger Andreas Dilger added a comment - Mr NeilBrown (neilb@suse.de) uploaded a new patch: https://review.whamcloud.com/40939 Subject: LU-13839 ldiskfs: fix detecting ext4_journal_ensure_credits Project: fs/lustre-release Branch: master Current Patch Set: 3 Commit: a25b7b26c3e722011686e762b80df64bd1d24749
          pjones Peter Jones added a comment -

          Server and client support on 2.14 and client support on 2.12.6

          pjones Peter Jones added a comment - Server and client support on 2.14 and client support on 2.12.6

          Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/40729/
          Subject: LU-13839 kernel: RHEL 8.3 server support
          Project: fs/lustre-release
          Branch: master
          Current Patch Set:
          Commit: cf48a2d23bca685e1076e45370c5d3763c9a9952

          gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/40729/ Subject: LU-13839 kernel: RHEL 8.3 server support Project: fs/lustre-release Branch: master Current Patch Set: Commit: cf48a2d23bca685e1076e45370c5d3763c9a9952

          James Nunez (jnunez@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/40884
          Subject: LU-13839 test: run review test groups
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 61958a097f340b51dc8f963b9429858dbdb610df

          gerrit Gerrit Updater added a comment - James Nunez (jnunez@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/40884 Subject: LU-13839 test: run review test groups Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 61958a097f340b51dc8f963b9429858dbdb610df
          yujian Jian Yu added a comment - - edited

          In RHEL 8.3 kernel 4.18.0-240.1.1.el8_3:

          • ext4_handle_has_enough_credits() was replaced with jbd2_handle_buffer_credits()
          • an extra "int revoke" argument was added to ext4_journal_extend() and ext4_journal_restart()

          All of the above conflicts are included in osd_extend_restart_trans(), which can be implemented with ext4_journal_ensure_credits() in the new kernel.

          The server support patch has been updated.

          yujian Jian Yu added a comment - - edited In RHEL 8.3 kernel 4.18.0-240.1.1.el8_3: ext4_handle_has_enough_credits() was replaced with jbd2_handle_buffer_credits() an extra "int revoke" argument was added to ext4_journal_extend() and ext4_journal_restart() All of the above conflicts are included in osd_extend_restart_trans(), which can be implemented with ext4_journal_ensure_credits() in the new kernel. The server support patch has been updated.
          yujian Jian Yu added a comment -

          The LDISKFS_DIR_REC_LEN issue was resolved in linux-5.4/ext4-data-in-dirent.patch.

          yujian Jian Yu added a comment - The LDISKFS_DIR_REC_LEN issue was resolved in linux-5.4/ext4-data-in-dirent.patch.
          yujian Jian Yu added a comment -

          RHEL 8.3 server build failed with the following errors:

            CC [M]  /root/root/lustre-release/ldiskfs/dir.o
          In file included from include/linux/rh_kabi.h:30,
                           from include/linux/fs.h:5,
                           from /root/root/lustre-release/ldiskfs/dir.c:25:
          /root/root/lustre-release/ldiskfs/dir.c: In function ‘__ldiskfs_check_dir_entry’:
          /root/root/lustre-release/ldiskfs/ldiskfs.h:2099:61: error: invalid type argument of ‘->’ (have ‘int’)
           #define LDISKFS_DIR_REC_LEN(de)  (__LDISKFS_DIR_REC_LEN((de)->name_len +\
                                                                       ^~
          include/linux/compiler.h:77:42: note: in definition of macro ‘unlikely’
           # define unlikely(x) __builtin_expect(!!(x), 0)
                                                    ^
          /root/root/lustre-release/ldiskfs/ldiskfs.h:2099:35: note: in expansion of macro ‘__LDISKFS_DIR_REC_LEN’
           #define LDISKFS_DIR_REC_LEN(de)  (__LDISKFS_DIR_REC_LEN((de)->name_len +\
                                             ^~~~~~~~~~~~~~~~~~~~~
          /root/root/lustre-release/ldiskfs/dir.c:81:41: note: in expansion of macro ‘LDISKFS_DIR_REC_LEN’
            else if (unlikely(next_offset > size - LDISKFS_DIR_REC_LEN(1) &&
                                                   ^~~~~~~~~~~~~~~~~~~
          /root/root/lustre-release/ldiskfs/dir.c:81:61: error: passing argument 1 of ‘ldiskfs_get_dirent_data_len’ makes pointer from integer without a cast [-Werror=int-conversion]
            else if (unlikely(next_offset > size - LDISKFS_DIR_REC_LEN(1) &&
                                                                       ^
          include/linux/compiler.h:77:42: note: in definition of macro ‘unlikely’
           # define unlikely(x) __builtin_expect(!!(x), 0)
                                                    ^
          /root/root/lustre-release/ldiskfs/ldiskfs.h:2099:35: note: in expansion of macro ‘__LDISKFS_DIR_REC_LEN’
           #define LDISKFS_DIR_REC_LEN(de)  (__LDISKFS_DIR_REC_LEN((de)->name_len +\
                                             ^~~~~~~~~~~~~~~~~~~~~
          /root/root/lustre-release/ldiskfs/dir.c:81:41: note: in expansion of macro ‘LDISKFS_DIR_REC_LEN’
            else if (unlikely(next_offset > size - LDISKFS_DIR_REC_LEN(1) &&
                                                   ^~~~~~~~~~~~~~~~~~~
          In file included from /root/root/lustre-release/ldiskfs/dir.c:29:
          /root/root/lustre-release/ldiskfs/ldiskfs.h:3531:75: note: expected ‘struct ldiskfs_dir_entry_2 *’ but argument is of type ‘int’
           static inline int ldiskfs_get_dirent_data_len(struct ldiskfs_dir_entry_2 *de)
                                                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
          cc1: all warnings being treated as errors
          make[5]: *** [scripts/Makefile.build:315: /root/root/lustre-release/ldiskfs/dir.o] Error 1
          make[5]: *** Waiting for unfinished jobs....
          
          /root/root/lustre-release/lustre/osd-ldiskfs/osd_io.c: In function ‘osd_extend_restart_trans’:
          /root/root/lustre-release/lustre/osd-ldiskfs/osd_io.c:1978:6: error: implicit declaration of function ‘ldiskfs_handle_has_enough_credits’; did you mean ‘ldiskfs_datasem_ensure_credits’? [-Werror=implicit-function-declaration]
            if (ldiskfs_handle_has_enough_credits(handle, needed))
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                ldiskfs_datasem_ensure_credits
          /root/root/lustre-release/lustre/osd-ldiskfs/osd_io.c:1981:7: error: too few arguments to function ‘ldiskfs_journal_extend’
            rc = ldiskfs_journal_extend(handle, needed - handle->h_buffer_credits);
                 ^~~~~~~~~~~~~~~~~~~~~~
          In file included from /root/root/lustre-release/lustre/osd-ldiskfs/osd_internal.h:54,
                           from /root/root/lustre-release/lustre/osd-ldiskfs/osd_io.c:56:
          /root/root/lustre-release/ldiskfs/ldiskfs_jbd2.h:349:19: note: declared here
           static inline int ldiskfs_journal_extend(handle_t *handle, int nblocks, int revoke)
                             ^~~~~~~~~~~~~~~~~~~~~~
          /root/root/lustre-release/lustre/osd-ldiskfs/osd_io.c:1985:7: error: too few arguments to function ‘ldiskfs_journal_restart’
            rc = ldiskfs_journal_restart(handle, needed);
                 ^~~~~~~~~~~~~~~~~~~~~~~
          In file included from /root/root/lustre-release/lustre/osd-ldiskfs/osd_internal.h:54,
                           from /root/root/lustre-release/lustre/osd-ldiskfs/osd_io.c:56:
          /root/root/lustre-release/ldiskfs/ldiskfs_jbd2.h:356:19: note: declared here
           static inline int ldiskfs_journal_restart(handle_t *handle, int nblocks,
                             ^~~~~~~~~~~~~~~~~~~~~~~
            CC [M]  /root/root/lustre-release/lustre/osp/osp_sync.o
          cc1: all warnings being treated as errors
          make[6]: *** [scripts/Makefile.build:315: /root/root/lustre-release/lustre/osd-ldiskfs/osd_io.o] Error 1
          make[6]: *** Waiting for unfinished jobs....
          
          yujian Jian Yu added a comment - RHEL 8.3 server build failed with the following errors: CC [M] /root/root/lustre-release/ldiskfs/dir.o In file included from include/linux/rh_kabi.h:30, from include/linux/fs.h:5, from /root/root/lustre-release/ldiskfs/dir.c:25: /root/root/lustre-release/ldiskfs/dir.c: In function ‘__ldiskfs_check_dir_entry’: /root/root/lustre-release/ldiskfs/ldiskfs.h:2099:61: error: invalid type argument of ‘->’ (have ‘int’) #define LDISKFS_DIR_REC_LEN(de) (__LDISKFS_DIR_REC_LEN((de)->name_len +\ ^~ include/linux/compiler.h:77:42: note: in definition of macro ‘unlikely’ # define unlikely(x) __builtin_expect(!!(x), 0) ^ /root/root/lustre-release/ldiskfs/ldiskfs.h:2099:35: note: in expansion of macro ‘__LDISKFS_DIR_REC_LEN’ #define LDISKFS_DIR_REC_LEN(de) (__LDISKFS_DIR_REC_LEN((de)->name_len +\ ^~~~~~~~~~~~~~~~~~~~~ /root/root/lustre-release/ldiskfs/dir.c:81:41: note: in expansion of macro ‘LDISKFS_DIR_REC_LEN’ else if (unlikely(next_offset > size - LDISKFS_DIR_REC_LEN(1) && ^~~~~~~~~~~~~~~~~~~ /root/root/lustre-release/ldiskfs/dir.c:81:61: error: passing argument 1 of ‘ldiskfs_get_dirent_data_len’ makes pointer from integer without a cast [-Werror=int-conversion] else if (unlikely(next_offset > size - LDISKFS_DIR_REC_LEN(1) && ^ include/linux/compiler.h:77:42: note: in definition of macro ‘unlikely’ # define unlikely(x) __builtin_expect(!!(x), 0) ^ /root/root/lustre-release/ldiskfs/ldiskfs.h:2099:35: note: in expansion of macro ‘__LDISKFS_DIR_REC_LEN’ #define LDISKFS_DIR_REC_LEN(de) (__LDISKFS_DIR_REC_LEN((de)->name_len +\ ^~~~~~~~~~~~~~~~~~~~~ /root/root/lustre-release/ldiskfs/dir.c:81:41: note: in expansion of macro ‘LDISKFS_DIR_REC_LEN’ else if (unlikely(next_offset > size - LDISKFS_DIR_REC_LEN(1) && ^~~~~~~~~~~~~~~~~~~ In file included from /root/root/lustre-release/ldiskfs/dir.c:29: /root/root/lustre-release/ldiskfs/ldiskfs.h:3531:75: note: expected ‘struct ldiskfs_dir_entry_2 *’ but argument is of type ‘int’ static inline int ldiskfs_get_dirent_data_len(struct ldiskfs_dir_entry_2 *de) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~ cc1: all warnings being treated as errors make[5]: *** [scripts/Makefile.build:315: /root/root/lustre-release/ldiskfs/dir.o] Error 1 make[5]: *** Waiting for unfinished jobs.... /root/root/lustre-release/lustre/osd-ldiskfs/osd_io.c: In function ‘osd_extend_restart_trans’: /root/root/lustre-release/lustre/osd-ldiskfs/osd_io.c:1978:6: error: implicit declaration of function ‘ldiskfs_handle_has_enough_credits’; did you mean ‘ldiskfs_datasem_ensure_credits’? [-Werror=implicit-function-declaration] if (ldiskfs_handle_has_enough_credits(handle, needed)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ldiskfs_datasem_ensure_credits /root/root/lustre-release/lustre/osd-ldiskfs/osd_io.c:1981:7: error: too few arguments to function ‘ldiskfs_journal_extend’ rc = ldiskfs_journal_extend(handle, needed - handle->h_buffer_credits); ^~~~~~~~~~~~~~~~~~~~~~ In file included from /root/root/lustre-release/lustre/osd-ldiskfs/osd_internal.h:54, from /root/root/lustre-release/lustre/osd-ldiskfs/osd_io.c:56: /root/root/lustre-release/ldiskfs/ldiskfs_jbd2.h:349:19: note: declared here static inline int ldiskfs_journal_extend(handle_t *handle, int nblocks, int revoke) ^~~~~~~~~~~~~~~~~~~~~~ /root/root/lustre-release/lustre/osd-ldiskfs/osd_io.c:1985:7: error: too few arguments to function ‘ldiskfs_journal_restart’ rc = ldiskfs_journal_restart(handle, needed); ^~~~~~~~~~~~~~~~~~~~~~~ In file included from /root/root/lustre-release/lustre/osd-ldiskfs/osd_internal.h:54, from /root/root/lustre-release/lustre/osd-ldiskfs/osd_io.c:56: /root/root/lustre-release/ldiskfs/ldiskfs_jbd2.h:356:19: note: declared here static inline int ldiskfs_journal_restart(handle_t *handle, int nblocks, ^~~~~~~~~~~~~~~~~~~~~~~ CC [M] /root/root/lustre-release/lustre/osp/osp_sync.o cc1: all warnings being treated as errors make[6]: *** [scripts/Makefile.build:315: /root/root/lustre-release/lustre/osd-ldiskfs/osd_io.o] Error 1 make[6]: *** Waiting for unfinished jobs....

          Jian Yu (yujian@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/40729
          Subject: LU-13839 kernel: RHEL 8.3 server support
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 958aac6c9f7a8e3c7f021134a31228a92ccf683d

          gerrit Gerrit Updater added a comment - Jian Yu (yujian@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/40729 Subject: LU-13839 kernel: RHEL 8.3 server support Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 958aac6c9f7a8e3c7f021134a31228a92ccf683d

          People

            yujian Jian Yu
            yujian Jian Yu
            Votes:
            1 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: