[LU-15421] Missing error() calls in test scripts

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.15.0
• Affects Version/s: Lustre 2.15.0
• Severity: 3
• Assignee: Oleg Drokin
• Reporter: Oleg Drokin

Description

Looks like we have several instances of errors that forget to call the error primitive

 

$ git grep '|| "' | grep -i fail
lustre/tests/sanity-flr.sh:    $LFS mirror read -N2 -o $TMP/$tfile $DIR/$tfile || "read mirror failed"
lustre/tests/sanity-flr.sh:    $LFS mirror write -N2 -i /etc/passwd $DIR/$tfile || "write failed"
lustre/tests/sanity-pfl.sh:    rm -f $comp_file || "Delete $comp_file failed"
lustre/tests/sanity-pfl.sh:    rm $comp_file || "Delete composite failed"
lustre/tests/sanity.sh:    createmany -d $DIR/$tdir/d 6 || "(2) fail to mkdir" 

and

lustre/tests/sanity-lfsck.sh:    cat $DIR/$tdir/$tfile && "$DIR/$tdir/$tfile: read should fail"
lustre/tests/sanity.sh:    touch $DIR/$tdir/$tdir/$tfile && "$DIR/$tdir: file create should fail"
lustre/tests/sanity.sh:    touch $DIR/$tdir/$tdir/$tfile && "$DIR/$tdir: file create should fail" 

Comments

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/45995/
Subject: LU-15421 tests: Add missing error() calls on errors
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 1ed7bf5c6a6d6bf786388d34342351d0c1aa7dfc

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/45995
Subject: LU-15421 tests: Add missing error() calls on errors
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 8cb64f85362ac745355f747590a9b20aac95cc7d