Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-15617

Add shellcheck to prepare-commit-msg

Details

    • Improvement
    • Resolution: Fixed
    • Minor
    • Lustre 2.16.0
    • None
    • None
    • 9223372036854775807

    Description

      Add shellcheck to prepare-commit-msg.

      Attachments

        Issue Links

          has to be done after

          Improvement - An improvement or enhancement to an existing feature or task. LU-15626 Fix "error" reported by shellcheck

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-14826 enable striped directory as NFS export

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. LU-15612 Replace unicode double quotes with ASCII(text)

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. LU-15614 Variable incorrectly used in sanity-flr/203

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. LU-15358 Fix shellcheck errors

          • Trivial - Cosmetic problem like misspelt words or misaligned text.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. LU-11673 Correct shell issues/mistakes in Lustre test suites

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            [LU-15617] Add shellcheck to prepare-commit-msg
            pjones Peter Jones made changes -
            Fix Version/s New: Lustre 2.16.0 [ 15190 ]
            Resolution New: Fixed [ 1 ]
            Status Original: Open [ 1 ] New: Resolved [ 5 ]
            pjones Peter Jones added a comment -

            Landed for 2.16

            pjones Peter Jones added a comment - Landed for 2.16
            gerrit Gerrit Updater added a comment -

            "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/46705/
            Subject: LU-15617 contrib: Add shellcheck to prepare-commit-msg
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 57abd991ade9a381ac3ec94ca1d02993378c8e7c

            gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/46705/ Subject: LU-15617 contrib: Add shellcheck to prepare-commit-msg Project: fs/lustre-release Branch: master Current Patch Set: Commit: 57abd991ade9a381ac3ec94ca1d02993378c8e7c
            pjones Peter Jones made changes -
            Assignee Original: WC Triage [ wc-triage ] New: Arshad Hussain [ arshad512 ]
            arshad512 Arshad Hussain made changes -
            Link New: This issue has to be done after LU-15626 [ LU-15626 ]
            arshad512 Arshad Hussain added a comment -

            Andreas, will have a go at this one LU-15617 & LU-15626 are done.

            arshad512 Arshad Hussain added a comment - Andreas, will have a go at this one LU-15617 & LU-15626 are done.
            adilger Andreas Dilger added a comment - - edited

            The other place where shellcheck could be usefully added (once it is working in prepare-commit-msg) is in contrib/scripts/gerrit-checkpatch.py, which is doing the actual work of calling checkpatch.pl on each submitted patch and posting comments on the patches in Gerrit.

            Like in prepare-commit-msg, it would need to determine which files are shell scripts, and then run shellcheck on the file and limit it to lines which are modified by the patch and call add_comment() for each one, and the script should handle the rest. The gerrit-checkpatch.py script is in Python, so I can't help very much with that, but hopefully it is fairly clear.

            adilger Andreas Dilger added a comment - - edited The other place where shellcheck could be usefully added (once it is working in prepare-commit-msg ) is in contrib/scripts/gerrit-checkpatch.py , which is doing the actual work of calling checkpatch.pl on each submitted patch and posting comments on the patches in Gerrit. Like in prepare-commit-msg , it would need to determine which files are shell scripts, and then run shellcheck on the file and limit it to lines which are modified by the patch and call add_comment() for each one, and the script should handle the rest. The gerrit-checkpatch.py script is in Python, so I can't help very much with that, but hopefully it is fairly clear.
            adilger Andreas Dilger made changes -
            Link New: This issue is related to LU-15612 [ LU-15612 ]
            adilger Andreas Dilger made changes -
            Link New: This issue is related to LU-15358 [ LU-15358 ]
            adilger Andreas Dilger made changes -
            Link New: This issue is related to LU-14826 [ LU-14826 ]
            adilger Andreas Dilger made changes -
            Link New: This issue is related to LU-15614 [ LU-15614 ]

            People

              arshad512 Arshad Hussain
              arshad512 Arshad Hussain
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: