Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-16565

Remove ldlm flag ldlm_{is,set,clear} macros

Details

    • Improvement
    • Resolution: Unresolved
    • Minor
    • None
    • None
    • None
    • 9223372036854775807

    Description

      We have macros like ldlm_{is,set,clear}_#FLAG_NAME# for all of the ldlm flags.  I'm going to remove them and convert all usages to just using the flag bit names directly.

      They make it much harder to find all uses of the actual lock flags and we are entirely inconsistent on whether we use the macros or not.  And since we're always going to use the flag names for multi-flag uses, we can't convert 100% to macros anyway.

      Attachments

        Activity

          [LU-16565] Remove ldlm flag ldlm_{is,set,clear} macros

          "Timothy Day <timday@amazon.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57543
          Subject: LU-16565 quota: Remove ldlm is,set,clear macros
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: f744d7fe15a79fa90a664912e404c848b9fb330a

          gerrit Gerrit Updater added a comment - "Timothy Day <timday@amazon.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57543 Subject: LU-16565 quota: Remove ldlm is,set,clear macros Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: f744d7fe15a79fa90a664912e404c848b9fb330a

          "Timothy Day <timday@amazon.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57542
          Subject: LU-16565 target: Remove ldlm is,set,clear macros
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: e6a437bca8734bfbe3e46f9a81f72d9b2b4b151f

          gerrit Gerrit Updater added a comment - "Timothy Day <timday@amazon.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57542 Subject: LU-16565 target: Remove ldlm is,set,clear macros Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: e6a437bca8734bfbe3e46f9a81f72d9b2b4b151f

          "Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50054
          Subject: LU-16565 ldlm: Remove ldlm is,set,clear macros
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 11108e29328c444f8801bd71574ef67cb28b7950

          gerrit Gerrit Updater added a comment - "Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50054 Subject: LU-16565 ldlm: Remove ldlm is,set,clear macros Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 11108e29328c444f8801bd71574ef67cb28b7950

          "Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50053
          Subject: LU-16565 ldlm: Remove ldlm is,set,clear macros
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 799f8d76d575452c68f829d112276937c611555f

          gerrit Gerrit Updater added a comment - "Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50053 Subject: LU-16565 ldlm: Remove ldlm is,set,clear macros Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 799f8d76d575452c68f829d112276937c611555f

          "Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50052
          Subject: LU-16565 ldlm: Remove ldlm is,set,clear macros
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 65bd32eee637b2e212141ef62b373df6b2ed6f40

          gerrit Gerrit Updater added a comment - "Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50052 Subject: LU-16565 ldlm: Remove ldlm is,set,clear macros Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 65bd32eee637b2e212141ef62b373df6b2ed6f40

          "Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50051
          Subject: LU-16565 ldlm: Remove ldlm is,set,clear macros
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 3109e4d50ad0c54be9fdd31141b82ca70a862b24

          gerrit Gerrit Updater added a comment - "Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50051 Subject: LU-16565 ldlm: Remove ldlm is,set,clear macros Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 3109e4d50ad0c54be9fdd31141b82ca70a862b24

          "Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50049
          Subject: LU-16565 ldlm: Remove ldlm is,set,clear macros
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 719c6a155c742b95e1d89f557eed94a36ab24450

          gerrit Gerrit Updater added a comment - "Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50049 Subject: LU-16565 ldlm: Remove ldlm is,set,clear macros Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 719c6a155c742b95e1d89f557eed94a36ab24450

          "Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50047
          Subject: LU-16565 ldlm: Remove ldlm is,set,clear macros
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 3d7e0826bd5b28a3e3c889863e17899d418710f8

          gerrit Gerrit Updater added a comment - "Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50047 Subject: LU-16565 ldlm: Remove ldlm is,set,clear macros Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 3d7e0826bd5b28a3e3c889863e17899d418710f8

          "Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50046
          Subject: LU-16565 ldlm: Remove ldlm is,set,clear macros
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 87679af288291494423be10b7b31b3b3be957a0e

          gerrit Gerrit Updater added a comment - "Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50046 Subject: LU-16565 ldlm: Remove ldlm is,set,clear macros Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 87679af288291494423be10b7b31b3b3be957a0e

          "Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50045
          Subject: LU-16565 ldlm: Remove ldlm is,set,clear macros
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 39e2e5b9b55e0d1443cd136d312845d3418ae2a7

          gerrit Gerrit Updater added a comment - "Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50045 Subject: LU-16565 ldlm: Remove ldlm is,set,clear macros Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 39e2e5b9b55e0d1443cd136d312845d3418ae2a7

          "Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50044
          Subject: LU-16565 ldlm: Remove ldlm is,set,clear macros
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 66bb7f56a9b22139ae999336bfe1bb222c9e0cd0

          gerrit Gerrit Updater added a comment - "Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50044 Subject: LU-16565 ldlm: Remove ldlm is,set,clear macros Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 66bb7f56a9b22139ae999336bfe1bb222c9e0cd0

          People

            paf0186 Patrick Farrell
            paf0186 Patrick Farrell
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated: