[LU-16565] Remove ldlm flag ldlm_{is,set,clear} macros - Whamcloud Community JIRA

Details

Type: Improvement
Resolution: Unresolved
Priority: Minor
Fix Version/s: None
Affects Version/s: None
Labels:
None

Rank (Obsolete):
9223372036854775807

Description

We have macros like ldlm_{is,set,clear}_#FLAG_NAME# for all of the ldlm flags. I'm going to remove them and convert all usages to just using the flag bit names directly.

They make it much harder to find all uses of the actual lock flags and we are entirely inconsistent on whether we use the macros or not. And since we're always going to use the flag names for multi-flag uses, we can't convert 100% to macros anyway.

Attachments

Activity

[LU-16565] Remove ldlm flag ldlm_{is,set,clear} macros

Gerrit Updater added a comment - 20/Dec/24 4:41 AM

"Timothy Day <timday@amazon.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57548
Subject: LU-16565 ldlm: [1] Remove ldlm is,set,clear macros
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d3699de9b2b46df3a4ab6fb9a4ae1066a62650ab

Gerrit Updater added a comment - 20/Dec/24 4:41 AM "Timothy Day <timday@amazon.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57548 Subject: LU-16565 ldlm: [1] Remove ldlm is,set,clear macros Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: d3699de9b2b46df3a4ab6fb9a4ae1066a62650ab

Gerrit Updater added a comment - 20/Dec/24 4:40 AM

"Timothy Day <timday@amazon.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57547
Subject: LU-16565 mdc: Remove ldlm is,set,clear macros
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 319750223098327e30d7b7e8bf25afb85bbc7b54

Gerrit Updater added a comment - 20/Dec/24 4:40 AM "Timothy Day <timday@amazon.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57547 Subject: LU-16565 mdc: Remove ldlm is,set,clear macros Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 319750223098327e30d7b7e8bf25afb85bbc7b54

Gerrit Updater added a comment - 20/Dec/24 4:40 AM

"Timothy Day <timday@amazon.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57546
Subject: LU-16565 llite: Remove ldlm is,set,clear macros
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: cc1f609e341f988ebc307f574768c347ec4af28d

Gerrit Updater added a comment - 20/Dec/24 4:40 AM "Timothy Day <timday@amazon.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57546 Subject: LU-16565 llite: Remove ldlm is,set,clear macros Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: cc1f609e341f988ebc307f574768c347ec4af28d

Gerrit Updater added a comment - 20/Dec/24 4:39 AM

"Timothy Day <timday@amazon.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57545
Subject: LU-16565 mdt: Remove ldlm is,set,clear macros
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 6f4081093a7efc417de8038b3bd61ad066254b17

Gerrit Updater added a comment - 20/Dec/24 4:39 AM "Timothy Day <timday@amazon.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57545 Subject: LU-16565 mdt: Remove ldlm is,set,clear macros Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 6f4081093a7efc417de8038b3bd61ad066254b17

Gerrit Updater added a comment - 20/Dec/24 4:38 AM

"Timothy Day <timday@amazon.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57544
Subject: LU-16565 osc: Remove ldlm is,set,clear macros
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 4ef61372cd8d05bfb46364bd54702d51ac15e72c

Gerrit Updater added a comment - 20/Dec/24 4:38 AM "Timothy Day <timday@amazon.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57544 Subject: LU-16565 osc: Remove ldlm is,set,clear macros Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 4ef61372cd8d05bfb46364bd54702d51ac15e72c

Gerrit Updater added a comment - 20/Dec/24 4:37 AM

"Timothy Day <timday@amazon.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57543
Subject: LU-16565 quota: Remove ldlm is,set,clear macros
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: f744d7fe15a79fa90a664912e404c848b9fb330a

Gerrit Updater added a comment - 20/Dec/24 4:37 AM "Timothy Day <timday@amazon.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57543 Subject: LU-16565 quota: Remove ldlm is,set,clear macros Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: f744d7fe15a79fa90a664912e404c848b9fb330a

Gerrit Updater added a comment - 20/Dec/24 4:34 AM

"Timothy Day <timday@amazon.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57542
Subject: LU-16565 target: Remove ldlm is,set,clear macros
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: e6a437bca8734bfbe3e46f9a81f72d9b2b4b151f

Gerrit Updater added a comment - 20/Dec/24 4:34 AM "Timothy Day <timday@amazon.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/57542 Subject: LU-16565 target: Remove ldlm is,set,clear macros Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: e6a437bca8734bfbe3e46f9a81f72d9b2b4b151f

Gerrit Updater added a comment - 17/Feb/23 5:52 PM

"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50054
Subject: LU-16565 ldlm: Remove ldlm is,set,clear macros
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 11108e29328c444f8801bd71574ef67cb28b7950

Gerrit Updater added a comment - 17/Feb/23 5:52 PM "Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50054 Subject: LU-16565 ldlm: Remove ldlm is,set,clear macros Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 11108e29328c444f8801bd71574ef67cb28b7950

Gerrit Updater added a comment - 17/Feb/23 5:51 PM

"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50053
Subject: LU-16565 ldlm: Remove ldlm is,set,clear macros
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 799f8d76d575452c68f829d112276937c611555f

Gerrit Updater added a comment - 17/Feb/23 5:51 PM "Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50053 Subject: LU-16565 ldlm: Remove ldlm is,set,clear macros Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 799f8d76d575452c68f829d112276937c611555f

Gerrit Updater added a comment - 17/Feb/23 5:51 PM

"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50052
Subject: LU-16565 ldlm: Remove ldlm is,set,clear macros
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 65bd32eee637b2e212141ef62b373df6b2ed6f40

Gerrit Updater added a comment - 17/Feb/23 5:51 PM "Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50052 Subject: LU-16565 ldlm: Remove ldlm is,set,clear macros Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 65bd32eee637b2e212141ef62b373df6b2ed6f40

Gerrit Updater added a comment - 17/Feb/23 4:59 PM

"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50051
Subject: LU-16565 ldlm: Remove ldlm is,set,clear macros
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 3109e4d50ad0c54be9fdd31141b82ca70a862b24

Gerrit Updater added a comment - 17/Feb/23 4:59 PM "Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50051 Subject: LU-16565 ldlm: Remove ldlm is,set,clear macros Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 3109e4d50ad0c54be9fdd31141b82ca70a862b24

People

Assignee:: Patrick Farrell

Reporter:: Patrick Farrell

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 16/Feb/23 10:49 PM

Updated:: 10/Apr/25 6:50 AM