[LU-166] MDR assert of wire dat for ATTR_BY_FID case

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.1.0
• Affects Version/s: Lustre 2.0.0, Lustre 2.1.0
• Severity: 3
• Assignee: nasf (Inactive)
• Reporter: Oleg Drokin

Description

mdt_getattr_name_lock has this code:

if (!info->mti_cross_ref) {
/*

• XXX: Check for "namelen == 0" is for getattr by fid
• (OBD_CONNECT_ATTRFID), otherwise do not allow empty name,
• that is the name must contain at least one character and
• the terminating '\0'
  */
  if (namelen == 0) {
  reqbody = req_capsule_client_get(info->mti_pill,
  &RMF_MDT_BODY);
  LASSERT(fid_is_sane(&reqbody->fid2));

This LASSERT is wrong because it depends on correctness of the client-supplied data.
Should be replaced with EPROTO error.