[LU-17000] Coverity static analysis issues

• Type: Improvement
• Resolution: Unresolved
• Priority: Minor
• Labels: easy
• Severity: 3
• Assignee: Tim Day
• Reporter: Tim Day

Description

I've been experimenting with more static analyzers (Coverity in this case). While it does have some false positives, it looks like it found a number of legitimate bugs. See https://scan.coverity.com/projects/lustre for details.

It's seems like Coverity has been used with Lustre in the past (see: https://wiki.lustre.org/images/8/8a/LUG2013-Lustre_Static_Code_Analysis-Bull.pdf). Although, it doesn't seem like it's been run in a while.

Also, there's a number of Coverity comments that seem out-dated and should probably just be cleaned up.

Issue Links

• is related to: LU-18560 ldiskfs_write_ldd(): Coverity reports issues
• is related to: LU-18608 Insecure data handling (INTEGER_OVERFLOW) /lustre/llite/pcc.c: pcc_io_fini() in pcc_file_read_iter()
• is related to: LU-19055 Missing unlock in ptlrpc_reconnect_if_idle
• is related to: LU-2753 Tracking bug for static code analysis fixes.
• is related to: LU-1855 Coverity: Fix 'out-of-bounds access' errors
• is related to: LU-1856 Coverity: Fix 'Out-of-bounds write' errors
• is related to: LU-1884 Coverity: Fix 'resource leak' errors
• is related to: LU-1857 Coverity: Fix 'Unbounded source buffer' errors
• is related to: LU-1889 Fix false 'uninitialized scalar variable' errors found by Coverity
• is related to: LU-1907 Remove function resolution mistakes made by Coverity
• is related to: LU-2709 Coverity: Fix 'memory corruption' errors
• is related to: LU-2710 Remove function resolution mistakes made by Coverity

Comments

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/59516/
Subject: LU-17000 utils: Fix error reported by coverity in lcfg_setparam_client
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 003005b13ec0db3a0708f01a94de8427323ff074

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/59477/
Subject: LU-17000 obdclass: Fix mem leak in pool_add_objects
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 0e9c25ce5f697f8f55d8008261ad467032669740

[Gerrit Updater]

"Arshad Hussain <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/60604
Subject: LU-17000 lst: Fix unsed variable reported by valgrind
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 6ee07aea10a6c30ff1c5368406682eaa3aff2677

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/60018/
Subject: LU-17000 utils: handle_yaml_no_op() has wrong signature
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 08eef833edc883dc59eea63b655245580f48bc87

[Gerrit Updater]

"Arshad Hussain <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/60040
Subject: LU-17000 osd: Fix Assign instead of compare in LASSERT
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 0e0e43df477adb51e24b467a68d9d6d787bd8507

[Gerrit Updater]

"James Simmons <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/60018
Subject: LU-17000 utils: handle_yaml_no_op() has wrong signature
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d6bdb5024a1d015a1246f3175f5a2f3f958ac60a

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/59499/
Subject: LU-17000 obdclass: Fix mem leak in lcfg_setparam_client
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 20e9f9bd769bcd10033fe3b70cfe257ff899893d

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/59456/
Subject: LU-17000 llite: Handle not NUL terminated buffer in ll_statahead_info
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 24a2a4ed6b2120aa21cbaad9496281ff69d1d7c2

[Gerrit Updater]

"Arshad Hussain <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/59516
Subject: LU-17000 utils: For test
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 6e3dc1c3bb9eef4f7dc85b76c69958f8e8e34255

[Gerrit Updater]

"Arshad Hussain <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/59499
Subject: LU-17000 obdclass: Fix mem leak in lcfg_setparam_client
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 477bebf6053a98a6cc24a1c40893c4625ea8e626

[Gerrit Updater]

"Arshad Hussain <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/59477
Subject: LU-17000 obdclass: Fix mem leak in pool_add_objects
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 0b773cb1e85e583843ad2906cacf37aef798b8ba